AZC0004 ensure that method signatures match #9388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is in Draft because I haven't test my changes yet. |
JonathanCrd
commented
Dec 9, 2024
src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers/ClientMethodsAnalyzer.cs
Outdated
Show resolved
Hide resolved
JonathanCrd
force-pushed
the
AZC0004-bug-fix
branch
from
83acc4b to
0b4834b
Compare
This reverts commit 0b4834b.
JonathanCrd
changed the title
JonathanCrd
requested review from
jsquire,
JoshLove-msft,
christothes,
annelo-msft,
KrzysztofCwalina,
tg-msft and
m-nash
as code owners
jsquire
reviewed
Dec 11, 2024
src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers/ClientMethodsAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers/ClientMethodsAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/dotnet/Azure.ClientSdk.Analyzers/Azure.ClientSdk.Analyzers/ClientMethodsAnalyzer.cs
Outdated
Show resolved
Hide resolved
JonathanCrd
changed the base branch from
main
to
JonathanCrd/dotnet_analyzer_fix_AZC0004_bug
|
This PR will go to a feature branch in order to test the changes against the Azure SDK for .Net repo. |
jsquire
approved these changes
Dec 11, 2024
JonathanCrd
merged commit 0ed0248
into
Azure:JonathanCrd/dotnet_analyzer_fix_AZC0004_bug
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6845
Currently, the analyzer does not ensure that both equivalent sync and async methods have the same return type and parameters. This PR adds a check for the return type and parameters of both methods to ensure that they match.