Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish JS parser using system identity #9143

Merged
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
5eef4cb
Publish JS parser using system identity
praveenkuttappan Oct 11, 2024
00f4e13
Add .npmrc to authenticate
praveenkuttappan Oct 11, 2024
756f36c
Additional npmrc changes
praveenkuttappan Oct 11, 2024
9a0044b
Additional npmrc changes
praveenkuttappan Oct 11, 2024
6a0106c
Merge branch 'main' into update_js_api_parser_publish
praveenkuttappan Oct 11, 2024
c045b56
npmrc changes
praveenkuttappan Oct 11, 2024
dc2fb3a
npmrc changes
praveenkuttappan Oct 11, 2024
52d20eb
Apply suggestions from code review
praveenkuttappan Jan 25, 2025
1be99cd
Update tools/apiview/parsers/js-api-parser/ci.yml
praveenkuttappan Jan 25, 2025
821b848
Update tools/apiview/parsers/js-api-parser/ci.yml
praveenkuttappan Jan 25, 2025
9a10131
Update tools/apiview/parsers/js-api-parser/ci.yml
praveenkuttappan Jan 25, 2025
8b8872b
Remove chckout skip step
praveenkuttappan Jan 25, 2025
2826787
Add missing tsp path
praveenkuttappan Jan 25, 2025
351d19e
Update npmrc
praveenkuttappan Jan 25, 2025
813ecff
Update npmrc
praveenkuttappan Jan 25, 2025
bc6cda1
Fix the auth script
praveenkuttappan Jan 25, 2025
9703290
Update add user step
praveenkuttappan Jan 25, 2025
2fc071b
Enable verbose logging for adduser
praveenkuttappan Jan 25, 2025
3ca7012
REpalce npm adduser with vsts auth
praveenkuttappan Jan 25, 2025
8fc8cd7
Update npm auth step
praveenkuttappan Jan 25, 2025
daeebef
Remove always auth code
praveenkuttappan Jan 26, 2025
66dcee2
Add npmrc file back
praveenkuttappan Jan 26, 2025
70f60af
remove existing npmrc. generate it during publishing only
scbedd Jan 29, 2025
ce33e76
dump some metadata about what was saved
scbedd Jan 29, 2025
ac2629d
I didn't commit a spelling correction
scbedd Jan 29, 2025
86afa92
try a direct npm publish in the same directory
scbedd Jan 29, 2025
d14183c
use npm custom. authenticate the user npmrc
scbedd Jan 29, 2025
15f3f67
dump the value before contining
scbedd Jan 29, 2025
c69d0b9
use user npmrc
scbedd Jan 29, 2025
400f7ed
attempt to use the user located npmrc
scbedd Jan 29, 2025
d8d0de2
revert all exploratory usage in favor of working configuration
scbedd Jan 30, 2025
4de800b
fix indentation
scbedd Jan 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/dotnet/APIView/APIViewWeb/APIViewWeb.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<JavaProcessor>..\..\..\java\apiview-java-processor\target\apiview-java-processor-1.31.0.jar</JavaProcessor>
<GoProcessor>..\..\..\go\apiviewgo.exe</GoProcessor>
<NpmRcForJS>..\..\..\..\tools\apiview\parsers\js-api-parser\.npmrc</NpmRcForJS>
praveenkuttappan marked this conversation as resolved.
Show resolved Hide resolved
<TypeScriptToolsVersion>latest</TypeScriptToolsVersion>
<TypeScriptCompileBlocked>true</TypeScriptCompileBlocked>
<SignAssembly>False</SignAssembly>
Expand Down Expand Up @@ -63,6 +64,7 @@
<ItemGroup>
<Content Include="$(GoProcessor)" Condition="Exists($(GoProcessor))" CopyToOutputDirectory="PreserveNewest" />
<Content Include="$(JavaProcessor)" Condition="Exists($(JavaProcessor))" CopyToOutputDirectory="PreserveNewest" />
<Content Include="$(NpmRcForJS)\**\*" Condition="Exists($(NpmRcForJS))" CopyToOutputDirectory="PreserveNewest" />
praveenkuttappan marked this conversation as resolved.
Show resolved Hide resolved
</ItemGroup>

<ItemGroup>
Expand Down
3 changes: 3 additions & 0 deletions tools/apiview/parsers/js-api-parser/.npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
registry=https://registry.npmjs.org/
@azure-tools:registry=https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-js/npm/registry/
@azure-tools:always-auth=true
33 changes: 16 additions & 17 deletions tools/apiview/parsers/js-api-parser/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@ extends:
- template: /eng/pipelines/templates/variables/image.yml
- name: ArtifactName
value: 'apiview'
- name: FeedRegistry
value: 'https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-js/npm/registry/'

jobs:
- job: PublishPackage
displayName: 'Publish ts-genapi package to devops feed'
Expand All @@ -96,18 +95,18 @@ extends:
- pwsh: |
$detectedPackageName=Get-ChildItem $(Pipeline.Workspace)/$(ArtifactName)/*.tgz
Write-Host "Detected package name: $detectedPackageName"
$registry="$(FeedRegistry)"
$regAuth=$registry.replace("https:","")
$npmReg = $regAuth.replace("registry/","");
$env:NPM_TOKEN="$(azure-sdk-devops-npm-token)"
Write-Host "Publishing to $($regAuth)"
npm config set $regAuth`:username=azure-sdk
npm config set $regAuth`:_password=`$`{NPM_TOKEN`}
npm config set $regAuth`:email=not_set
npm config set $npmReg`:username=azure-sdk
npm config set $npmReg`:_password=`$`{NPM_TOKEN`}
npm config set $npmReg`:email=not_set
Write-Host "Publishing package"
Write-Host "npm publish $detectedPackageName --registry=$registry --always-auth=true"
npm publish $detectedPackageName --registry=$registry --always-auth=true
displayName: Publish package
Write-Host "##vso[task.setvariable variable=PackageArtifactFullPath]$detectedPackageName"
displayName: "Find package artifact"

- task: npmAuthenticate@0
inputs:
workingFile: $(TypeScriptGeneratorDirectory)/.npmrc
praveenkuttappan marked this conversation as resolved.
Show resolved Hide resolved

- task: Npm@1
inputs:
command: 'custom'
customCommand: 'publish $(PackageArtifactFullPath)'
publishRegistry: useFeed
publishFeed: "public/azure-sdk-for-js"
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
praveenkuttappan marked this conversation as resolved.
Show resolved Hide resolved
Loading