Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish JS parser using system identity #9143

Merged

Conversation

praveenkuttappan
Copy link
Member

Publish JS parser using system identity

@praveenkuttappan praveenkuttappan self-assigned this Oct 11, 2024
@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Oct 11, 2024
Copy link

Hi @praveenkuttappan. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Dec 13, 2024
Copy link

Hi @praveenkuttappan. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Dec 21, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Jan 9, 2025
@praveenkuttappan
Copy link
Member Author

Fixes #9694

@praveenkuttappan
Copy link
Member Author

@chidozieononiwu It still fails when publishing even after authenticating. I am not sure if this is because a package already exists. Npm sometimes fails with incorrect error message so we might have to try publishing a package version that doesn't exists.

@scbedd
Copy link
Member

scbedd commented Jan 30, 2025

@praveenkuttappan @benbp it is working when invokingnpm publish in the working directory with the authed .npmrc. The only reason the latest build is failed is because we already published the version in this PR.

I did try to update the user .npmrc, and keep using the npm task (assuming that the user .npmrc was being used for auth), but nothing I tried with that worked.

@praveenkuttappan
Copy link
Member Author

Thanks a lot @scbedd for this change.

@praveenkuttappan praveenkuttappan merged commit dd0058d into Azure:main Jan 30, 2025
11 checks passed
@scbedd scbedd self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Status: 🎊 Closed
Development

Successfully merging this pull request may close these issues.

4 participants