Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAT Removal from pipeline generation yml #8370

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

JimSuplizio
Copy link
Member

This is the second PR, the one that removes the usage of azuresdk-azure-sdk-devops-pipeline-generation-pat.

Note: As of right now, this PR is incomplete. This PR relies on another PR being merged, publishing a new version of the pipeline-generator and the version of install-pipeline-generation.yml being updated to the published version. That needs to be part of this PR and will be updated once the other one is removed.

@JimSuplizio JimSuplizio requested review from weshaggard June 3, 2024 17:40
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

@JimSuplizio JimSuplizio marked this pull request as ready for review June 4, 2024 20:32
@JimSuplizio JimSuplizio requested a review from a team as a code owner June 4, 2024 20:32
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@JimSuplizio
Copy link
Member Author

You will need to update also update https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/pipelines/templates/steps/install-pipeline-generation.yml#L12

Yes, I called that out in the description. The other PR, with the source changes, had to get merged and published first. The 3rd commit updates the version and that file is part of this PR.

JimSuplizio added a commit to Azure/azure-sdk-for-js that referenced this pull request Jun 4, 2024
@JimSuplizio JimSuplizio enabled auto-merge (squash) June 4, 2024 21:12
@JimSuplizio JimSuplizio merged commit 0eec660 into Azure:main Jun 4, 2024
10 checks passed
@JimSuplizio JimSuplizio deleted the RemovePATVarYml branch June 4, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants