Remove PATVAR from PipelineGenerator #8369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
reviewed
Jun 3, 2024
tools/pipeline-generator/Azure.Sdk.Tools.PipelineGenerator/PipelineGenerationContext.cs
Outdated
Show resolved
Hide resolved
…urePowerShell credentials
…e, it'll happen there not some random place
hallipr
approved these changes
Jun 4, 2024
|
I need to override check-enforcer as there's nothing that runs when this tool is changed, only when it's checked in. |
|
/check-enforcer override |
benbp
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the PAT removal effort. The PAT being removed is azuresdk-azure-sdk-devops-pipeline-generation-pat. This PR is the first of two, the second PR will update the yml files remove the usage of azuresdk-azure-sdk-devops-pipeline-generation-pat. The second PR requires this to be published first so the version of pipeline-generator in install-pipeline-generator.yml can be updated.
There was a hacked up version of pipeline-generation.yml that was used to test these changes, this was the successful run after updates. The hacked up yml file has been removed from this PR.
The second PR will use an
AzureCLI@2task to authenticate and call pipeline-generation within the task's inlinescript.