Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate tag push #5748

Merged
merged 10 commits into from
Apr 17, 2023
Merged

Prevent duplicate tag push #5748

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9b2b9ff
we use the generated SHA of the assets repo within the tag name that …
scbedd Mar 18, 2023
ef4c84e
Update tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs
scbedd Mar 21, 2023
ca26d19
Merge remote-tracking branch 'upstream/main' into hotfix/prevent-dupl…
scbedd Apr 13, 2023
528521d
identify the error with my push logic
scbedd Apr 13, 2023
ccb0b96
update integration tests?
scbedd Apr 13, 2023
d04b0c6
commit test fix
scbedd Apr 13, 2023
34f20b6
progress for the night this is entirely broken
scbedd Apr 14, 2023
7f38137
Reducing missing cleanup items
scbedd Apr 14, 2023
8b8b785
repair cli integration tests
scbedd Apr 15, 2023
d29c270
repair the tests to account for the newly updated test helpers
scbedd Apr 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tools/test-proxy/Azure.Sdk.Tools.TestProxy/Store/GitStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,20 @@ public async Task Push(string pathToAssetsJson) {
}

GitHandler.Run($"tag {generatedTagName}", config);
GitHandler.Run($"push origin {generatedTagName}", config);

var remoteResult = GitHandler.Run($"ls-remote origin --tags {generatedTagName}", config);

if (remoteResult.ExitCode != 0)
{
if (string.IsNullOrWhiteSpace(remoteResult.StdOut))
{
GitHandler.Run($"push origin {generatedTagName}", config);
}
else
{
_consoleWrapper.WriteLine("Not attempting to push new tag, as we have found it already within the assets repo");
scbedd marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
catch(GitProcessException e)
{
Expand Down