Prevent duplicate tag push #5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is uploaded. This means that if a set of recordings has already been pushed, we won't attempt to push again and error out
scbedd
added
the
Asset-Sync
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
reviewed
Mar 21, 2023
benbp
approved these changes
Mar 21, 2023
Co-authored-by: Ben Broderick Phillips <[email protected]>
|
Unfortunately I broke the integration tests somehow so this won't be going in as-is. |
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
benbp
approved these changes
Apr 13, 2023
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run tools - test-proxy - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and ensure that ending up with a duplicate tag offers a seamless path forward.
Addresses #5712
This PR also updates some of the TestHelper infrastructure to:
assetsconfig to a pushed integration tag (from C# integration tests). We were leaking tags from the C# integration tests. (Note the multiple additionalassetscleanups)