Extend APIView Search to support PullRequest in General Search #5586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maririos
approved these changes
Mar 10, 2023
| @@ -217,6 +217,7 @@ public async Task<IEnumerable<string>> GetReviewFirstLevelPropertiesAsync(string | |||
| queryStringBuilder.Append($" OR CONTAINS(r.Name, {query}, true)"); | |||
| queryStringBuilder.Append($" OR CONTAINS(r.ServiceName, {query}, true)"); | |||
| queryStringBuilder.Append($" OR CONTAINS(r.PackageDisplayName, {query}, true)"); | |||
| queryStringBuilder.Append($" OR ENDSWITH(ARRAY_SLICE(r.Revisions, -1)[0].Label, {query}, true)"); | |||
There was a problem hiding this comment.
I am a bit late to comment here. But CONTAINS would have been better here instead of Endswith to avoid any assumption that PR number will always be at the end of label. Label is generated by each language side script, and there is no specific rule for naming convention, and it can add any additional info in the future without knowing it will break in APIVIew side search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support searching by pull request in general search.
Resolves #5465