Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIView bug with search bar #5465

Closed
tjprescott opened this issue Feb 15, 2023 · 3 comments · Fixed by #5586
Closed

APIView bug with search bar #5465

tjprescott opened this issue Feb 15, 2023 · 3 comments · Fixed by #5586
Assignees
@chidozieononiwu
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@tjprescott
Copy link
Member

If I search for PKI, I find my APIView:
image

However, if I put the PR number in the search box, it finds nothing:
image
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 15, 2023
@maririos maririos added APIView and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 15, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Feb 15, 2023
@praveenkuttappan
Copy link
Member

@tjprescott You can search for API reviews created from a PR using pr:10562

@praveenkuttappan
Copy link
Member

@chidozieononiwu Can you please update README to include instructions about search filters we support.

@tjprescott
Copy link
Member Author

Thanks @praveenkuttappan though I would argue that if the APIView includes the PR number, just a plain text search for the PR number should work without a "pr:" prefix (which is unintuitive).

@mikekistler mikekistler mentioned this issue Feb 23, 2023
Closed
@mikekistler mikekistler added the Central-EngSys This issue is owned by the Engineering System team. label Feb 23, 2023
@mikekistler mikekistler moved this from 🆕 New to 📋 Backlog in ApiView Feb 23, 2023
@chidozieononiwu chidozieononiwu mentioned this issue Mar 1, 2023
Merged
@praveenkuttappan praveenkuttappan moved this from 🤔Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Mar 1, 2023
@praveenkuttappan praveenkuttappan moved this from 🐝 Dev to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Mar 1, 2023
@praveenkuttappan praveenkuttappan moved this from 📋 Backlog to 🏗 In progress in ApiView Mar 1, 2023
@github-project-automation github-project-automation bot moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Mar 10, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in ApiView Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chidozieononiwu chidozieononiwu

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extend APIView Search to support PullRequest in General Search chidozieononiwu/azure-sdk-tools
5 participants
@tjprescott @maririos @chidozieononiwu @praveenkuttappan @mikekistler