Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment update: clarify we need sdk in install-dotnet.yml due to asp.net core runtime #5428

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Comment update: clarify we need sdk in install-dotnet.yml due to asp.net core runtime #5428

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6b2415
clarify why we need 'sdk' in UseDotNet@2
Feb 13, 2023
45c904e
Update eng/pipelines/templates/steps/install-dotnet.yml
Feb 13, 2023
5e5aaf0
Remove link to build
Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions eng/pipelines/templates/steps/install-dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,17 @@ steps:
retryCountOnTaskFailure: 3
inputs:
# We must install sdk, not just runtime, as it is required by some of our tools, like test-proxy.
# For additional context, see PR: https://github.com/Azure/azure-sdk-tools/pull/5405
# Specifically, test-proxy requires asp.net core runtime, which is installed only when sdk option
konrad-jamrozik marked this conversation as resolved.
Show resolved Hide resolved
# is selected, per: https://github.com/microsoft/azure-pipelines-tasks/issues/14405
#
# For additional context, see:
# https://github.com/Azure/azure-sdk-tools/pull/5405#discussion_r1105006774
# https://github.com/Azure/azure-sdk-tools/pull/5405
packageType: sdk
version: 6.0.x
# performMultiLevelLookup comes into play when given .NET executable target runtime is different
# than the installed .NET SDK. Without this, such runtime would not be found.
performMultiLevelLookup: true

# Future work: add NuGet packages caching. See:
# https://github.com/Azure/azure-sdk-tools/issues/5086
# https://github.com/Azure/azure-sdk-tools/issues/5086