Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment update: clarify we need sdk in install-dotnet.yml due to asp.net core runtime #5428

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Comment update: clarify we need sdk in install-dotnet.yml due to asp.net core runtime #5428

merged 3 commits into from
Feb 13, 2023

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Feb 13, 2023 •
edited
Loading

@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Feb 13, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Feb 13, 2023
@konrad-jamrozik konrad-jamrozik requested review from weshaggard, benbp and a team February 13, 2023 21:30
@konrad-jamrozik konrad-jamrozik changed the title Clarify we need sdk in install-dotnet.yml due to sp.net core runtime Clarify we need sdk in install-dotnet.yml due to asp.net core runtime Feb 13, 2023
@konrad-jamrozik konrad-jamrozik changed the title Clarify we need sdk in install-dotnet.yml due to asp.net core runtime Clarify we need sdk in install-dotnet.yml due to asp.net core runtime Feb 13, 2023
@konrad-jamrozik konrad-jamrozik marked this pull request as ready for review February 13, 2023 21:32
@konrad-jamrozik konrad-jamrozik mentioned this pull request Feb 13, 2023
Merged
@konrad-jamrozik konrad-jamrozik changed the title Clarify we need sdk in install-dotnet.yml due to asp.net core runtime Comment update: clarify we need sdk in install-dotnet.yml due to asp.net core runtime Feb 13, 2023
weshaggard
weshaggard approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the build link otherwise looks good.

@konrad-jamrozik
Copy link
Contributor Author

@weshaggard should I remove the build link even with this?

image

I always manually retain builds I link to.

@weshaggard
Copy link
Member

@weshaggard should I remove the build link even with this?_

I'd say it still isn't worth it. If you want log messages to be maintained I'd suggest copying the part that is interesting into this PR so folks could find it later if needed.

@konrad-jamrozik
Copy link
Contributor Author

/check-enforcer override

@konrad-jamrozik konrad-jamrozik merged commit 4da5527 into main Feb 13, 2023
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/aspnetruntime_comment branch February 13, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@scbedd scbedd scbedd approved these changes

@benbp benbp Awaiting requested review from benbp

Assignees

@konrad-jamrozik konrad-jamrozik

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@konrad-jamrozik @weshaggard @scbedd