Show associated PRS and associated reviews in review page #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidozieononiwu
force-pushed
the
feature/PullRequestLink
branch
from
a78d9b9 to
d964176
Compare
| </ul> | ||
| } | ||
| } | ||
| @if (Model.Review.Language == "Swagger" && Model.Review.FilterType == ReviewType.PullRequest) |
There was a problem hiding this comment.
Let's not limit this to swagger only. We should support showing linked PR API reviews on any language. Similarly, it should show related API reviews from same PR for when they open even SDK level API reviews.
For e.g. Assume that user opened .NET API review generated from swagger and he wants to see associated reviews like swagger, cadl, Python etc.
chidozieononiwu
force-pushed
the
feature/PullRequestLink
branch
from
d964176 to
a4b9425
Compare
praveenkuttappan
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #5143 and #5142