Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIVIew - Show link to pull request on API review generated from pull request #5143

Closed
praveenkuttappan opened this issue Jan 14, 2023 · 0 comments · Fixed by #5417
Closed

APIVIew - Show link to pull request on API review generated from pull request #5143

praveenkuttappan opened this issue Jan 14, 2023 · 0 comments · Fixed by #5417
Assignees
@chidozieononiwu
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

API reviews are generated from pull requests. Architects would like to have a easier way of navigating to pull request from API review if APi review is generated from pull request. Currently they have to look at the label and then go to repo to find the pull request.

We should show a link at the top of the API review to navigate to pull request.

Generated API review from pull request

API review link can be generated using repo name and pull request number in PullRequests Cosmos container.
@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Jan 14, 2023
@praveenkuttappan praveenkuttappan self-assigned this Jan 14, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Jan 14, 2023
@praveenkuttappan praveenkuttappan moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🚢🎉 Jan 19, 2023
@maririos maririos moved this from 🆕 New to 📋 Backlog in ApiView Jan 21, 2023
This was referenced Jan 27, 2023
Closed
Closed
@maririos maririos moved this from 📋 Backlog to 🏗 In progress in ApiView Feb 8, 2023
@chidozieononiwu chidozieononiwu mentioned this issue Feb 11, 2023
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in ApiView Feb 13, 2023
@github-project-automation github-project-automation bot moved this from 📋Backlog to 🎊Closed in Azure SDK EngSys 🚢🎉 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chidozieononiwu chidozieononiwu

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show associated PRS and associated reviews in review page chidozieononiwu/azure-sdk-tools
2 participants
@chidozieononiwu @praveenkuttappan