-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test-Proxy] During recording, re-use existing request body #5304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In playback this isn't an issue because the decompressed payload is deterministic. The compressed payload is not. |
… is usable by dotnet
Co-authored-by: JoshLove-msft <[email protected]>
JoshLove-msft
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We are seeing an extremely odd behavior during recording of monitor ingestion tests. Specifically the upload of logs.
When running from within the .NET test framework, some of the requests that look this:
Randomly 400 with
badrequest
@JoshLove-msft is suspicious that gzip may be non-deterministic when compressing/recompressing. Not that the content itself is an issue, but the
Content-Length
headers WOULD be an issue if this were the case. If the header doesn't match by a couple bytes, its very possible that the service could throw back a 400 bad request at us.What we'll do here is bypass that issue by merely keeping the original request bytes around and essentially paste them into the upstream request.
I'm somewhat concerned that if it can happen there, why wouldn't it happen during playback as well (where we HAVE to recompress as we need to decompress to sanitize). Worth a try though.