Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prioritized] Feature req: option to not serialize/deserialize request body #3015

Open
timovv opened this issue Mar 30, 2022 · 1 comment
Open
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Test-Proxy Anything relating to test-proxy requests or issues.

Comments

@timovv
Copy link
Member

timovv commented Mar 30, 2022

As I mentioned in the sync yesterday:

Some methods for ACR require validation of the response body against a Docker-Content-Digest header. The test proxy serializes the response body during recording mode and deserializes it during playback, which causes any whitespace in the response body to be discarded. This means that the recomputed digest is different to what is in the Docker-Content-Digest header, causing tests to pass in live/record mode but fail in playback mode.

An option where the test proxy does not serialize the response body (so it just records it byte-for-byte, regardless of the content type) would be fantastic.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 30, 2022
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Apr 25, 2022
@scbedd scbedd added the Test-Proxy Anything relating to test-proxy requests or issues. label May 11, 2022
@kurtzeborn kurtzeborn moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🚢🎉 Nov 7, 2022
@scbedd scbedd changed the title [Test proxy] Feature req: option to not serialize/deserialize request body [Prioritize] Feature req: option to not serialize/deserialize request body Feb 9, 2023
@scbedd
Copy link
Member

scbedd commented Feb 9, 2023

@timovv we may have accidentally fixed this with another PR. Can you try repro-ing this against this new version?

Edit, ah you need to store the content during playback with this too. I don't think the fix addresses your problem entirely.

@scbedd scbedd changed the title [Prioritize] Feature req: option to not serialize/deserialize request body [Prioritized] Feature req: option to not serialize/deserialize request body Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Test-Proxy Anything relating to test-proxy requests or issues.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants