-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create API review for JS packages with namespace in api extractor model #5292
Create API review for JS packages with namespace in api extractor model #5292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Sample API review with this fix: https://apiviewstaging.azurewebsites.net/Assemblies/Review/f6bdaff7a9824ad0a96f13d0da57ad70 @MaryGao FYI.... |
/check-enforcer override |
/azp run APIView - CI |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run APIView - CI |
Azure Pipelines successfully started running 1 pipeline(s). |
@praveenkuttappan I notice that all tokens under namespace are un-clickable, do you know why? Could we someone fix it? To say we have a declaration type This type is used by post method under interface |
This one doesn't look like we can resolve with a quick fix in APIView due to the metadata returned by api-extractor itself which is outside the APIView system. I will have a look and talk to someone JS team. |
API review JSON input file has namespace model and all public API details are under this namespace model. APIView parser currently ignores namespace and any below members which causes issues for packages that has all it's members under a namespace. For e.g API review for change in PR https://github.com/Azure/azure-sdk-for-js-pr/pull/236/files#diff-6dc05287911739aecce4b2d7cbc4df5699df151c14f032b5a14990cd3f5b2762 is empty.
This PR will process namespace model and its child nodes.