Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API review is empty for JS #5287

Closed
praveenkuttappan opened this issue Jan 31, 2023 · 3 comments
Closed

API review is empty for JS #5287

praveenkuttappan opened this issue Jan 31, 2023 · 3 comments
Assignees
Labels
APIView Central-EngSys This issue is owned by the Engineering System team. DPG Impact Impact DPG

Comments

@praveenkuttappan
Copy link
Member

API extractor output file JSON has different schema than the one expected by parser. Currently API parser for JS does not process namespace token so it ignores any children under namesapce token. Parser expects Interface/class/struct as first level token kind to generate API review.

We should support creating API review when interface/class are within a namespace as well.

@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Jan 31, 2023
@praveenkuttappan praveenkuttappan self-assigned this Jan 31, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in ApiView Jan 31, 2023
@praveenkuttappan praveenkuttappan moved this from 🤔Triage to 📋Backlog in Azure SDK EngSys 🚢🎉 Jan 31, 2023
@lirenhe lirenhe added the DPG Impact Impact DPG label Feb 1, 2023
@lirenhe
Copy link
Member

lirenhe commented Feb 1, 2023

@praveenkuttappan, I saw this issue was added into backlog but it may impact the arch board review for DPG services.
We may also use multi-client in OpenAI service in the near future.
I added ‘DPG impact’ lable and could you work on it with high priority? Thanks.

cc @maririos

@praveenkuttappan praveenkuttappan moved this from 🆕 New to 🏗 In progress in ApiView Feb 1, 2023
@praveenkuttappan
Copy link
Member Author

@lirenhe I have already submitted a PR to resolve this and it's merged. It will soon get released and deployed to production.
#5292

@praveenkuttappan praveenkuttappan moved this from 📋Backlog to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Feb 1, 2023
@MaryGao
Copy link
Member

MaryGao commented Feb 1, 2023

@praveenkuttappan I notice that all tokens under namespaces are un-clickable do you know how to fix it?

More details: #5292 (comment)

@praveenkuttappan praveenkuttappan moved this from 🏗 In progress to ✅ Done in ApiView Feb 6, 2023
@maririos maririos closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team. DPG Impact Impact DPG
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants