Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test-proxy always logs exceptions on console #5218

Merged
merged 2 commits into from
Jan 26, 2023
Merged

test-proxy always logs exceptions on console #5218

merged 2 commits into from
Jan 26, 2023

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jan 25, 2023

Related to #5204

@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Jan 25, 2023
@scbedd scbedd self-assigned this Jan 25, 2023
@scbedd scbedd requested a review from mikeharder as a code owner January 25, 2023 18:51
benbp
benbp approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion but LGTM either way.

@scbedd scbedd merged commit 318ea75 into Azure:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

@mikeharder mikeharder Awaiting requested review from mikeharder mikeharder is a code owner

Assignees

@scbedd scbedd

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scbedd @benbp