Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-Proxy common usage updates #5204

Closed
2 tasks done
scbedd opened this issue Jan 24, 2023 · 1 comment
Closed
2 tasks done

Test-Proxy common usage updates #5204

scbedd opened this issue Jan 24, 2023 · 1 comment
Assignees
@scbedd
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@scbedd
Copy link
Member

scbedd commented Jan 24, 2023 •
edited
Loading

Discovered as part of a discussion with @LarryOsterman about usability improvements

  • Upload test-proxy.log artifact by default
  • Ensure that we dump the exception to console in all cases (regardless of verbosity level)evel)
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Jan 24, 2023
@scbedd scbedd self-assigned this Jan 24, 2023
This was referenced Jan 25, 2023
Merged
Merged
ghost pushed a commit that referenced this issue Jan 27, 2023
@scbedd
Add Template for Upload of Proxy Logs (#5224)
21c4863 
If you're using a simple invocation of the `test-proxy-tool.yml`, you will be able to call the following before your tests run.

```yml
- template: /eng/common/testproxy/test-proxy-tool.yml
  parameters:
    rootFolder: $(Build.SourcesDirectory)/sdk/core
```

One will be able to call:

```yml
- template: /eng/common/testproxy/publish-proxy-logs.yml
  parameters:
    rootFolder: $(Build.SourcesDirectory)/sdk/core
```

As long as you reflect the same `rootFolder` argument to publish-proxy-logs, they will be picked up and uploaded as artifacts.

[Example Invocation](https://dev.azure.com/azure-sdk/public/_build/results?buildId=2139544)

What the artifacts look like:
![image](https://user-images.githubusercontent.com/45376673/214681466-57ea5311-bc54-44ca-b2b9-acdec929238c.png)

Resolves the other half of #5204
@scbedd scbedd moved this from 🤔Triage to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Jan 27, 2023
@scbedd
Copy link
Member Author

scbedd commented Jan 27, 2023

Resolved with the two mentioned PRs.

@scbedd scbedd closed this as completed Jan 27, 2023
@github-project-automation github-project-automation bot moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scbedd scbedd

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scbedd