Give the csv flexibility to onboard "not New" package to Docs.Ms #4985
Conversation
sima-zhu
force-pushed
the
update_doc_logic
branch
from
a2cbb63 to
9ec2f9e
Compare
sima-zhu
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| } | ||
|
|
||
| # For deprecated packages, add "(deprecated)" besides of display name. | ||
| function GetDocsTocDisplayName($pkg) { |
There was a problem hiding this comment.
Where is this getting used?
There was a problem hiding this comment.
This is needed for language-setting in each language repo
There was a problem hiding this comment.
I have a PR for your reference. Azure/azure-sdk-for-net#33109
Triggered the pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2065510&view=results
Co-authored-by: Ben Broderick Phillips <[email protected]>
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Problem:
For package which is not "New" to csv, we have to use package.json to onboard the package. However, the best practice is to depend on csv file as many as possible. The PR change here is to add flexibility to use csv to onboard a new package.
New onboard rule:
Pros:
In this way, we can also push people to update
ms.serviceas many as possible. If somehow we don't have the rightms.service, then we can useplaceholderfor temporary placement.Testing onboarding logic:
durabletask-azure-functionsin package.jsondurabletask-azure-functionsin csv is havingfunctionsinMsDocService, andfalseinNew.Testing on deprecated message: