[In testing]Sync eng/common update doc logic 4985 for test pipeline #33109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
changed the title
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Dec 21, 2022
**Problem**: For package which is not "New" to csv, we have to use package.json to onboard the package. However, the best practice is to depend on csv file as many as possible. The PR change here is to add flexibility to use csv to onboard a new package. **New onboard rule:** 1. If package sets "New" to true, then we will onboard the package. 2. If package sets some value to "MSDocService", then we will onboard the package. 3. If nothing set for these two fields, then the package will not onboard to Docs.Ms. **Pros:** In this way, we can also push people to update `ms.service` as many as possible. If somehow we don't have the right `ms.service`, then we can use `placeholder` for temporary placement. Testing onboarding logic: 1. Testing in Java, removed the `durabletask-azure-functions` in [package.json](https://github.com/azure-sdk/azure-docs-sdk-java/blob/main/package.json) 2. `durabletask-azure-functions` in csv is having `functions` in `MsDocService`, and `false` in `New`. 3. After docindex pipeline, the changes show up here: https://github.com/Azure/azure-docs-sdk-java/blob/daily/2022-12-15/package.json#L1054 <img width="544" alt="image" src="https://user-images.githubusercontent.com/48036328/208503572-d292b6a6-1eec-41f1-b112-b37e7d8307a6.png"> Testing on deprecated message: 1. .NET testing PR: Azure/azure-sdk-for-net#33109 2. Testing on review site: https://review.learn.microsoft.com/en-us/dotnet/api/overview/azure/storage?view=azure-dotnet&branch=daily%2F2022-12-15-ci-succeeded <img width="321" alt="image" src="https://user-images.githubusercontent.com/48036328/208749147-61c46ea3-5f58-489a-ac02-bd9e54ad6c55.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.