Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily pin Node 18 to 18.13.0 #5536

Closed
mikeharder opened this issue Feb 22, 2023 · 0 comments · Fixed by #5537
Closed

Temporarily pin Node 18 to 18.13.0 #5536

mikeharder opened this issue Feb 22, 2023 · 0 comments · Fixed by #5537
Assignees
@mikeharder
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@mikeharder
Copy link
Member

Node versions 18.14.0 and 18.14.1 include npm 9.3.1, which includes a breaking change (nodejs/node#46542) that is impacting https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/pipelines/templates/steps/check-spelling.yml.

As a workaround, we should temporarily pin to Node 18.13.0, and revert when our build agents have upgraded to 18.14.2.
@mikeharder mikeharder added the Central-EngSys This issue is owned by the Engineering System team. label Feb 22, 2023
@mikeharder mikeharder self-assigned this Feb 22, 2023
@mikeharder mikeharder mentioned this issue Feb 22, 2023
Closed
mikeharder added a commit to mikeharder/azure-sdk-tools that referenced this issue Feb 22, 2023
@mikeharder
Temporarily pin Node 18 to 18.13.0
348aee3 
- Fixes Azure#5536
@mikeharder mikeharder mentioned this issue Feb 22, 2023
Merged
@mikeharder mikeharder moved this from 🤔Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Feb 22, 2023
@mikeharder mikeharder moved this from 🐝 Dev to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Feb 22, 2023
@ghost ghost closed this as completed in #5537 Feb 22, 2023
ghost pushed a commit that referenced this issue Feb 22, 2023
@mikeharder
[check-spelling] Temporarily pin Node 18 to 18.13.0 (#5537)
8a02e02 
- Fixes #5536
@github-project-automation github-project-automation bot moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Feb 22, 2023
@mikeharder mikeharder moved this from 🎊Closed to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Feb 22, 2023
@kurtzeborn kurtzeborn moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Feb 23, 2023
@mikeharder mikeharder moved this from 🎊Closed to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Mar 17, 2023
@mikeharder mikeharder moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Mar 17, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikeharder mikeharder

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[check-spelling] Temporarily pin Node 18 to 18.13.0 mikeharder/azure-sdk-tools
1 participant
@mikeharder