Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node 18 >= 18.14.2 #24946

Closed
mikeharder opened this issue Feb 21, 2023 · 1 comment
Closed

Use Node 18 >= 18.14.2 #24946

mikeharder opened this issue Feb 21, 2023 · 1 comment
Assignees
@mikeharder
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@mikeharder
Copy link
Member

Node 18.14.0 and 18.14.1 include npm 9.3.1, which has a breaking change related to how local dependencies are installed: nodejs/node#46542

This breaks pipeline js - template - ci:

https://dev.azure.com/azure-sdk/public/_build/results?buildId=2206943&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=2102385d-609d-5572-64d2-932661c7902f&l=30

When installing Node 18, we should require >= 18.14.2 to avoid this isssue.
@mikeharder mikeharder added the Central-EngSys This issue is owned by the Engineering System team. label Feb 21, 2023
@mikeharder mikeharder self-assigned this Feb 21, 2023
@mikeharder mikeharder moved this from 🤔Triage to 🐝 Dev in Azure SDK EngSys 🚢🎉 Feb 21, 2023
@mikeharder mikeharder mentioned this issue Feb 21, 2023
Merged
@mikeharder
Copy link
Member Author

Closing in favor of Azure/azure-sdk-tools#5536

@github-project-automation github-project-automation bot moved this from 🐝 Dev to 🎊Closed in Azure SDK EngSys 🚢🎉 Feb 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mikeharder mikeharder

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikeharder