Key Vault: making poller return Certificate or CertificateOperation #7349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
chlowell
reviewed
Sep 20, 2019
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/_polling.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/client.py
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/samples/list_operations.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/tests/test_examples_certificates.py
Outdated
Show resolved
Hide resolved
chlowell
approved these changes
Sep 23, 2019
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/aio/client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/samples/recover_purge_operations.py
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/azure/keyvault/certificates/client.py
Outdated
Show resolved
Hide resolved
sdk/keyvault/azure-keyvault-certificates/tests/test_examples_certificates_async.py
Outdated
Show resolved
Hide resolved
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Sep 28, 2019
…into base_to_properties * 'master' of https://github.com/Azure/azure-sdk-for-python: Eventhub tracing (Azure#7153) [devtools-cognitiveservices] temp fix to allow passing cog key in headers for azure-core (Azure#7471) adds back create mgmt client (Azure#7470) Update SDK Tools Consumption (Azure#7148) [AutoPR] peering/resource-manager (Azure#6923) Key Vault: making poller return Certificate or CertificateOperation (Azure#7349) Patch os.environ in Identity mock tests (Azure#7452) Unskip urllib3 related test (Azure#7442)
YijunXieMS
pushed a commit
to YijunXieMS/azure-sdk-for-python
that referenced
this pull request
Oct 9, 2019
…zure#7349) * async_request failing in sync client during playback * switched to returning certificate, all tests passing * updated create_certificate retval in docstrings * added Charles' comments * implemented Charles' comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.