Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK Tools Consumption #7148

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Update SDK Tools Consumption #7148

merged 1 commit into from
Sep 27, 2019

Conversation

chidozieononiwu
Copy link
Member

Update method of consuming SDK tools to use resources and templates.

@adxsdk6
Copy link

adxsdk6 commented Sep 9, 2019

Can one of the admins verify this patch?

@chidozieononiwu
Copy link
Member Author

/azp run python - cognitiveservices - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chidozieononiwu
Copy link
Member Author

/azp run python - storage - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member

scbedd commented Sep 10, 2019

I believe this is the order of ops for the builds:

client -> archtype sdk-nightly -> test-nightly
archtype-sdk-tests -> build-test
archtype-sdk-client -> build-test

So basically what I'm saying is that resources definition is necessary at archtype-sdk-client and sdk-tests ymls.

scbedd
scbedd requested changes Sep 10, 2019
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment. The failing CI reflects my claims I think.

@chidozieononiwu
Copy link
Member Author

The Issue with the resources is you can't add them at a template level. Since archtype-sdk-tests and archtype-sdk-client are both templates I had to go all the way back to the yml that call them. The CI fails due to error in pylint step. Queuing python - cognitiveservices - ci again.

@chidozieononiwu
Copy link
Member Author

/azp run python - cognitiveservices - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chidozieononiwu chidozieononiwu force-pushed the UpdateSDKConsumptionStory branch from 9ccac3f to 162bd09 Compare September 17, 2019 00:16
@chidozieononiwu chidozieononiwu force-pushed the UpdateSDKConsumptionStory branch from 162bd09 to 8e6c412 Compare September 26, 2019 23:01
@chidozieononiwu chidozieononiwu force-pushed the UpdateSDKConsumptionStory branch from 8e6c412 to 7fa429d Compare September 26, 2019 23:43
@scbedd
Copy link
Member

scbedd commented Sep 27, 2019

@chidozieononiwu the eventhub failure is known and they are working on it. I don't believe it's related to your changes.

@chidozieononiwu chidozieononiwu merged commit c9e6ded into Azure:master Sep 27, 2019
@chidozieononiwu chidozieononiwu deleted the UpdateSDKConsumptionStory branch September 27, 2019 20:19
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 28, 2019
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
6bcadf6 
…into base_to_properties

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Eventhub tracing (Azure#7153)
  [devtools-cognitiveservices] temp fix to allow passing cog key in headers for azure-core (Azure#7471)
  adds back create mgmt client (Azure#7470)
  Update SDK Tools Consumption (Azure#7148)
  [AutoPR] peering/resource-manager (Azure#6923)
  Key Vault: making poller return Certificate or CertificateOperation (Azure#7349)
  Patch os.environ in Identity mock tests (Azure#7452)
  Unskip urllib3 related test (Azure#7442)
YijunXieMS pushed a commit to YijunXieMS/azure-sdk-for-python that referenced this pull request Oct 9, 2019
@chidozieononiwu
Update SDK Tools Consumption (Azure#7148)
572cbc9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chidozieononiwu @adxsdk6 @scbedd @weshaggard