-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML][Pipelines] feat: support data binding expression inside entity runsettings #29559
Merged
wangchao1230
merged 8 commits into
Azure:main
from
elliotzh:zhangxingzhi/support-data-binding-expression-in-resources
Mar 27, 2023
Merged
[ML][Pipelines] feat: support data binding expression inside entity runsettings #29559
wangchao1230
merged 8 commits into
Azure:main
from
elliotzh:zhangxingzhi/support-data-binding-expression-in-resources
Mar 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotzh
requested review from
wangchao1230,
DouglasXiaoMS and
TonyJ1
as code owners
March 24, 2023 02:00
ghost
added
the
Machine Learning
label
Mar 24, 2023
elliotzh
changed the title
fix: support data binding expression for resources.xxx
[DO NOT MERGE] fix: support data binding expression for resources.xxx
Mar 24, 2023
API change check APIView has identified API level changes in this PR and created following API reviews. |
wangchao1230
approved these changes
Mar 24, 2023
elliotzh
requested review from
paulshealy1,
singankit,
diondrapeck,
luigiw,
harneetvirk,
kdestin,
MilesHolland,
needuv,
nemanjarajic and
nthandeMS
as code owners
March 24, 2023 03:55
elliotzh
force-pushed
the
zhangxingzhi/support-data-binding-expression-in-resources
branch
from
March 24, 2023 09:01
dcbf37c
to
e994794
Compare
elliotzh
changed the title
[DO NOT MERGE] fix: support data binding expression for resources.xxx
[ML][Pipelines] feat: support data binding expression inside entity runsettings
Mar 24, 2023
lalala123123
approved these changes
Mar 27, 2023
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 27, 2023
…into network_ga * 'main' of https://github.com/Azure/azure-sdk-for-python: (63 commits) check only once whether artifact extension exists (Azure#29594) code and test (Azure#29530) fix: support data binding expression for resources.xxx (Azure#29559) code and test (Azure#29558) [ServiceBus] enable sovereign cloud testing (Azure#29202) [AutoRelease] t2-communication-2023-03-20-22792(can only be merged by SDK owner) (Azure#29453) [Identity] Allow configurable process timeouts (Azure#28290) Increment package version after release of azure-containerregistry (Azure#29582) Update optional (Azure#28435) [Monitor][Query] Add sample notebook for large queries (Azure#28148) Update CHANGELOG.md (Azure#29580) [ServiceBus] remove msrest (Azure#29324) Explicitly set PSNativeCommandArgumentPassing to Legacy for git push script (Azure#29554) [ML][Pipelines] Support queue settings in pipeline job (Azure#29209) add experimental decorator for datatransfer (Azure#29562) Featurestore/online store crud new pr (Azure#29546) switch tooling over to typespec (Azure#29501) set up base path for feature set in load function (Azure#29544) Address credential description in docstring (Azure#29549) [Monitor] Regen query and ingestion (Azure#29504) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For now, data binding expression got some issues inside a run setting entity:
Full list of similar runsettings:
resources
queue_setting
- do not support for now as it involved value mapping in_to_rest_object
limits
resources
limits
resources
identity
- do not support for now as the only field foridentity
istype
and it has not been exposed to customersentry
- do not support for now as entry overwrite from node is forbidden for nowresources
limits
Sample error msg:
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines