-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ServiceBus] remove msrest #29324
[ServiceBus] remove msrest #29324
Conversation
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/servicebus/azure-servicebus/azure/servicebus/_common/utils.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_model_workaround.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_management_client.py
Outdated
Show resolved
Hide resolved
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Show resolved
Hide resolved
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review LGTM!
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @swathipil! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…into network_ga * 'main' of https://github.com/Azure/azure-sdk-for-python: (63 commits) check only once whether artifact extension exists (Azure#29594) code and test (Azure#29530) fix: support data binding expression for resources.xxx (Azure#29559) code and test (Azure#29558) [ServiceBus] enable sovereign cloud testing (Azure#29202) [AutoRelease] t2-communication-2023-03-20-22792(can only be merged by SDK owner) (Azure#29453) [Identity] Allow configurable process timeouts (Azure#28290) Increment package version after release of azure-containerregistry (Azure#29582) Update optional (Azure#28435) [Monitor][Query] Add sample notebook for large queries (Azure#28148) Update CHANGELOG.md (Azure#29580) [ServiceBus] remove msrest (Azure#29324) Explicitly set PSNativeCommandArgumentPassing to Legacy for git push script (Azure#29554) [ML][Pipelines] Support queue settings in pipeline job (Azure#29209) add experimental decorator for datatransfer (Azure#29562) Featurestore/online store crud new pr (Azure#29546) switch tooling over to typespec (Azure#29501) set up base path for feature set in load function (Azure#29544) Address credential description in docstring (Azure#29549) [Monitor] Regen query and ingestion (Azure#29504) ...
Removing msrest + re-generating ServiceBusAdministrationClient
Updated based on swagger at https://github.com/Azure/azure-rest-api-specs/blob/main/specification/servicebus/data-plane/Microsoft.ServiceBus/stable/2021-05/servicebus.json#L519
azure.core.exceptions.HttpResponseError
s are raised instead ofmsrest.ValidationError
s.related to [EventHubs&ServiceBus] remove msrest import from _amqp_message #26571