Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] change tags for Cosmos SDK team #25891

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Conversation

simorenoh
Copy link
Member

Most of the issues filed for the SDK team get the tags Cosmos and Client by the azure-bot, rather than Service Attention. These changes would help us get notified faster than having to be manually checking or getting manually tagged by others.

Most of the issues filed for the SDK team get the tags Cosmos and Client by the azure-bot, rather than Service Attention. These changes would help us get notified faster than having to be manually checking or getting manually tagged by others.
@ronniegeraghty
Copy link
Member

@simorenoh the bot rule is not for notifying the SDK team, it is for notifying the Service Team when an issue on the SDK repos requires their attention.

@simorenoh
Copy link
Member Author

simorenoh commented Aug 26, 2022

@ronniegeraghty so this change in the tags wouldn't change this behavior? I'm basically trying to make it so we get automatically tagged like we used to by msftbot:
image

@ronniegeraghty
Copy link
Member

@simorenoh Sorry, forgot the Cosmos SDK was owned by the Service Team.
@rohit-ganguly & @lmazuel, I'll check with @jsquire once he's back to see if this will affect any other part of the triage process, but I also wanted to check with you as the language owners.

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unusual, but it won't break any existing automation. I'd like for us to add this as a second rule rather than changing the "Service Attention" rule, however. There are times the management team will route management SDK issues for Swagger to the service teams.

@simorenoh
Copy link
Member Author

@jsquire went ahead and did those changes then, thanks!

@simorenoh simorenoh requested a review from jsquire August 29, 2022 16:19
@ronniegeraghty ronniegeraghty merged commit 6aa7443 into main Aug 29, 2022
@ronniegeraghty ronniegeraghty deleted the simorenoh-patch-1 branch August 29, 2022 20:13
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
* [Cosmos] change tags for Cosmos SDK team

Most of the issues filed for the SDK team get the tags Cosmos and Client by the azure-bot, rather than Service Attention. These changes would help us get notified faster than having to be manually checking or getting manually tagged by others.

* Update fabricbot.json
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Sep 28, 2023
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-08-02-preview (Azure#25891)

* Adds base for updating Microsoft.ContainerService/aks from version preview/2023-07-02-preview to version 2023-08-02-preview

* Updates readme

* Updates API version in new specs and examples

* update (Azure#25469)

* Fix the IstioComponents structure (Azure#25492)

* add netorkPolicy "none" (Azure#25511)

* add netorkPolicy "none" value and description

* add "none" enum value to networkPolicy

* add addon autoscaling api (Azure#25479)

* Update trusted access put and delete to async operation (Azure#25537)

* Update trusted access put and delete to async operation

* Update example

* Update header

* Swagger changes for adding autoscalerprofile flags for daemonset/multipleexpander (Azure#25487)

* Adding json changes

* adding "daemonsets" to the custom-words

* Editing "Expander" to "expander"

* Removing daemonset custom word from this pr. look at: Azure/azure-rest-api-specs#25533

* Add AzureServiceMesh example (Azure#25560)

* Add AzureServiceMesh example

* Fix AKV resource id format

* enrich ASM examples (Azure#25598)

---------

Co-authored-by: deveshdama <[email protected]>
Co-authored-by: robogatikov <[email protected]>
Co-authored-by: Chih-Sheng Huang <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Youn Jae Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants