Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Update typing annotations for CaseInsensitive Dictionary #25537

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

kashifkhan
Copy link
Member

@kashifkhan kashifkhan commented Aug 3, 2022

Changes for typing after API Review

  • in setitem value should be Any, while key should str since we are lowering the case for it

  • data can either be a Mapping or iterable of KV mappings

  • iter should be Iterator[str]

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core

@kashifkhan
Copy link
Member Author

/check-enforcer override

@kashifkhan kashifkhan merged commit 9e13f97 into Azure:main Aug 4, 2022
@kashifkhan kashifkhan deleted the azcore_dict_typing branch August 8, 2022 19:11
wonder6845 pushed a commit to wonder6845/azure-sdk-for-python that referenced this pull request Aug 23, 2022
…e#25537)

* update typing annotations

* change type

* typing fix

* fix type

* line too long pylint
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Sep 28, 2023
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-08-02-preview (Azure#25891)

* Adds base for updating Microsoft.ContainerService/aks from version preview/2023-07-02-preview to version 2023-08-02-preview

* Updates readme

* Updates API version in new specs and examples

* update (Azure#25469)

* Fix the IstioComponents structure (Azure#25492)

* add netorkPolicy "none" (Azure#25511)

* add netorkPolicy "none" value and description

* add "none" enum value to networkPolicy

* add addon autoscaling api (Azure#25479)

* Update trusted access put and delete to async operation (Azure#25537)

* Update trusted access put and delete to async operation

* Update example

* Update header

* Swagger changes for adding autoscalerprofile flags for daemonset/multipleexpander (Azure#25487)

* Adding json changes

* adding "daemonsets" to the custom-words

* Editing "Expander" to "expander"

* Removing daemonset custom word from this pr. look at: Azure/azure-rest-api-specs#25533

* Add AzureServiceMesh example (Azure#25560)

* Add AzureServiceMesh example

* Fix AKV resource id format

* enrich ASM examples (Azure#25598)

---------

Co-authored-by: deveshdama <[email protected]>
Co-authored-by: robogatikov <[email protected]>
Co-authored-by: Chih-Sheng Huang <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Youn Jae Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants