Resolve Failing Weekly Storage LiveTests #24843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
annatisch,
tasherif-msft,
jalauzon-msft and
vincenttran-msft
as code owners
ghost
added
the
|
These test failures are not related to my change. Overriding and merging. |
|
/check-enforcer override |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Sep 23, 2023
[Hub Generated] Review request for Microsoft.ConfidentialLedger to add version preview/2023-06-28-preview (#24632) * Adds base for updating Microsoft.ConfidentialLedger from version preview/2023-01-26-preview to version 2023-06-28-preview * Updates readme * Updates API version in new specs and examples * added running state and mccf update example * added backup and restore for ledger and mccf * updated backup restore specs * Sync fork (#25422) * Update readme.md for latest SDK release (#24618) Updating tag to release official SDKs based on latest preview version * [typespec-ci] Add pr trigger for eng/tools/TypeSpecValidation (#24640) * Azure OpenAI: reuse LRO response model as status polling model (#24556) * Azure OpenAI: reuse LRO response model as status polling model * incorporate unreachable type omission for limitation of breaking change triggers * batch rename for new LRO tack * Updates after clarification on sync parity snap * Update: adjustments after re-snap to plans for converged sync API * Adjustments based on feedback and .NET viability experiments * Example naming update (caught by CI) * Example update * PR feedback and re-disabling ts (will treat separately) * [TypeSpecValidation/ Format document (#24642) * Typespec EGv2 Clean CI (#24361) * update to ResourceAction * add eventgrid to ci * example files to be added * publishexample model after 2018-01-01 * dummyfile * casing * remove enum doc Co-authored-by: Mike Harder <[email protected]> * add examples * update to just be 200 responses for now * fix warnings * response body * remove additional properties * remove additional prop 2 * ran prettier * spacing * format * namespace got deleted * remove utf-8 * format * format * nit sample * Add specification/eventgrid to PR triggers * update tsp format * add package dir to c# * .NET still using directory-name * update package-dir * try without quotes like previous config * namespace * namespaces * dir of V2 as in feature branch * commenting out csharp gen --------- Co-authored-by: Mike Harder <[email protected]> * [typespec-ci] Discard git changes (#24650) - Feature was accidentally lost in the bash-to-TypeScript conversion * adding mutability flag to the identity property ACS (#24477) * adding mutability flag to the identity property ACS * Updated base tag to package preview 2023-04 * fix prettier issues * Add new stable API-version 2023-05-01 in Microsoft.Dataprotection (#24011) * Base commit from 2023-01-01 * Change API-version from 2023-01-01 to 2023-05-01 * Add hooks changes in Microsoft.Dataprotection * Correctness fix resProperties,rehydrationPriority Signed-off-by: SHASHANK SINGH <[email protected]> * revert latest commit * Add change for secureScore, Correctness fix resProperties,rehydrationPriority and update readme files * Add example regarding change for secureScore * Removing readonly secureScore from request * Using UserAssignedIdentity from common-types definitions --------- Signed-off-by: SHASHANK SINGH <[email protected]> Co-authored-by: SHASHANK SINGH <[email protected]> Co-authored-by: amchandn <[email protected]> * update (#24655) * [TypeSpecValidation] Enable simple-git logging (#24656) * Add multi-vector support to search requests (#24614) * Fixing the API-version in ManagedServices examples (#24578) * Fixing the API-version in ManagedServices examples * Addressing the swagger errors * Addressing the Location header issue on Delete Registration assignment Async operation response * [Hub Generated] Review request for Microsoft.NotificationHubs to add version preview/2023-01-01-preview (#24072) * Adds base for updating Microsoft.NotificationHubs from version stable/2017-04-01 to version 2023-01-01-preview * Updates readme * Updates API version in new specs and examples * Notification Hubs: adding API version 2023-01-01-preview * Notification Hubs: udpating custom words * Notification Hubs: updating custom-words * Changing zoneRedundant (boolean) to zoneRedundancy (enum), making Network ACLs optional * Notification Hubs: updating examples * Notification Hubs: fixing property name * Notification Hubs: fixing examples * Notification Hubs: resolving some of PR comments * Notification Hubs: adding x-ms-long-running-operation to one of Private Link operations * Notification Hubs: removing internal MoveResourceRequest * Notification Hubs: fixing merge marker * Notification Hubs: fixing zoneRedundancy * Notification Hubs: updating Swagger * Notification Hubs: updating samples * Notification Hubs: renaming $count to $top * Notification Hubs: removing 200 response from PrivateEndpointConnection.Delete * Notification Hubs: fixing async operation annotations * NotificationHubs: suppressing linter error * Notification Hubs: fixing async operation annotations * Notification Hubs: fixing async operation annotations * Notification Hubs: removing 201 for three operations * Notification Hubs: adding back response 201 for Notification Hubs - Create or Update * Notification Hubs: cleanup in 201 status codes * Notification Hubs: updating ids in examples * Notification Hubs: updating two examples * fist add reademe.go.md (#24674) * Updated correlationInterval example value (#24584) * add 'location' in example parameter (#24675) * update example parameter (#24676) * update example parameter * update file * add typescript.md for new service (#24694) * Form Recognizer v3.1 GA (2023-07-31) (#24634) * Copy 2023-02-28-preview to 2023-07-31 * v3.1 GA changes * Update documentation for REST docs * Add 2023-06-01-preview for Web PubSub (#24268) * Original commit * Add 2023-06-01-preview for signalr and webpubsub * remove no-op Avocado suppressions (#24703) * Improve automation comment contents formatting (#24704) * fix update example files for docs generation (#24710) * fix update example files for docs generation * fix prettier issues --------- Co-authored-by: Joel Enikanorogbon <[email protected]> * FabricBot: Onboarding to GitOps.ResourceManagement because of FabricBot decommissioning (#24716) * Add prIssueManagement.yml to onboard repo to GitOps.ResourceManagement as FabricBot replacement Owners of the FabricBot configuration should have received email notification. The same information contained in the email is published internally at: https://aka.ms/gim/fabricbot. Details on the replacement service and the syntax of the new yaml configuration file is available publicly at: https://microsoft.github.io/GitOps/policies/resource-management.html Please review and merge this PR to complete the process of onboarding to the new service. * Deleting fabricbot.json --------- Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> * Adding formatting on save for ts files (#24646) * Adding formatting on save for ts files * scoping to eng folder * cleanup * aligning prettier with typespec repo * update tsv.ts formatting * scoping typescript prettier to entire repo * revert package-lock * Added devcontainer for spec writers (#24622) * Added devcontainer for spec authors * Adding dockerfile * Adding comment * Adding convenient usage and conventions of the sdk repo path * change MongoDbAtlasDriver name (#24709) Co-authored-by: Zehua Chen <[email protected]> * Remove annotations (#24723) * [Hub Generated] Publish private branch 'release-managedNetworkFabric-GA' (#24673) * add or modify files * Updating the readme.md 1. removing the private-preview data * Removing the dotnet-sdk error * Resolving the issue caused due to the backward compatibility. * S360 Item - Missing Get SubscriptionOperations for 2021-10-01 version. (#24395) * Resolving S320 Item - Missing Get SubscriptionOperations for 2021-10-01 version. * Fix pipeline suggestions. * Minor fix. * Make Get Subscription operations sync in this version. * Added suppress rules for failing lint errors. * Fix suppression Issues. * Minor fix suppression GetOperation200. * Address minor fixes. * Address GetOperation200 changes. * Update readme.md: attempt suppression fix by adding ["202"] to "responses" to path --------- Co-authored-by: Abhay Pratap <[email protected]> Co-authored-by: Konrad Jamrozik <[email protected]> * add auth and fix some generated code issue in .net (#24725) * add auth and fix some generated code issue in .net * fixed style issue and revert property name change * removed unused options in JS emitter * Updated namespace value to Azure.Template * revert examples-directory config change * Update ci-fix cadl -> TypeSpec update (#24535) * Update codeowners for postgresql (#24456) Got a new team created in Azure org @Azure/azure-sdk-write-postgresql * Add base64 formatting to contentInBase64 property (#24617) * Add base64 formatting to contentInBase64 property * Update base64 string * Update base64 example string in SendEmail.json * [Hub Generated] Review request for Microsoft.DevCenter to add version preview/2023-07-01-preview (#24291) * Adds base for updating Microsoft.DevCenter from version preview/2023-01-01-preview to version 2023-07-01-preview * Updates readme * Updates API version in new specs and examples * Add schedule and troubleshoot APIs, add generic id property, update examples * Add troubleshoot example and update environment examples * Add ID to project * Add environment operations API * Re-add last operation ID * Run prettier * Add ID to delay result * Add suppression for host parameters validation * Remove last operation ID * Update with aligned operations API, URI property, file type log response * Remove old examples * Fix naming * Update TTL to 90 days on operations, add delete operationkind * Add sourceType * Remove old model * Use an enum for status * Consolidate on "sourceUri" for consistency with "uri" property * Description updates * Add NotStarted state * Add default response and missing LRO options to resolve LintDiff warning. * [Contoso.WidgetManager] Fix formatting (#24744) - Fixes CI for #24725 * [Maps Search] Fix the array parameters in examples (#24658) * Fix the array parameters in examples * Prettier fix * [OpenAI.Inference] Adding support for OpenAI functions. (#24534) * Adding 2023-07-01-preview * updating codegen * Adding definitions for functions. * fixes * updates * regenerated * updating examples * Updating based on some PR feedback --------- Co-authored-by: Travis Wilson <[email protected]> Co-authored-by: Travis Wilson <[email protected]> * [TypeSpec Validation] Move compile from "postinstall" to "build" (#24745) - Compiling in "postinstall" breaks existing tools that copy "package.json" from repo root to spec folder * Update Pricesheet properties for savingsPlan (#24708) * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update consumption.json * Update consumption.json * Update PriceSheet.json * elasticsan preview refresh microsoft.elasticsan 2022-12-01-preview (#24494) * Adds base for updating Microsoft.ElasticSan from version preview/2021-11-20-preview to version 2022-12-01-preview * Updates readme * Updates API version in new specs and examples * Added PE related changes * Added Private Link resource API * Nit change to correct the path for privateLinkResource API * Updated Lint errors * prettier check * resolved comments & added publicNetworkAccess * removed publicNetworkAccess & NIT changes * Updated the list operations * resolved lintDiff * proper value for examples and removed value from PECollections * resolved comments * spell check resolved * removing volumeCreateParameter * [Hub Generated] Publish private branch 'InbalZim-storagemover-Microsoft.StorageMover-RPSaaSMaster-2023-07-01-preview' (#24390) * add or modify files * Updated `credentials` models according to PR #24318 + reverted unwanted changes to `readme.md` * Removed URI format from SMB credentials to support it receiving empty string in order to clean-up their value * Removed extra hierarchy of `AzureStorageFileShareEndpointBaseProperties` * improve NR Examples (#24636) * improve NR Examples * addressing AutoRun Errors * Fixing Prettier Issue * Adding NextLink in Max Examples * Formatting Azure Resource Id * Updating Format of azure subscriptionIds * update code owner (#24754) * Update readme.python.md (#24758) * [TypeSpecValidation] Refactor package.json (#24756) - Improves upon #24745 - Creates eng/tools/package.json for all EngSys tools - Moves "postinstall" to eng/tools/TypeSpecValidation/package.json - Technically incorrect if the package were ever to be published to a registry - In practice, the best way I have found so far to use source-based tools in a TypeScript repo * workflow-bot comments: update breaking changes alternative C to point to alternative B (#24770) * [Communication] Job Router Public Preview v2022-07-18 (#23804) * Updated JR swagger with maxNumberOfJobs * job scheduling swagger changes * Enforce DistributionMode.kind to be read-only * retry with removing Required tag from abstract property for DistributionMode * WorkerState stopped showing up in generated swagger * Add reofferTimeUtc to decline offer API * Prettier * Prettier * rename WorkerState to RouterWorkerState * more fixes in polymorphic types * Rename decline offer request * prettier fix * add example for scheduled job * cpsell fix * fix response schema validation error * address review feedback item round 1 * SDK review changes * More API changes * Update distribution mode required properties * Renamings * job matching mode added * prettier fixes * fix examples refs * update ref examples * update swagger spec * fix enum mismatch * change operator to labelOperator in classification policy get and update ops example * Update specification/communication/data-plane/JobRouter/preview/2022-07-18-preview/communicationservicejobrouter.json Co-authored-by: Liangying.Wei <[email protected]> * hide redundant communicationerror and communicationerrorresponse during codegen * revert commit * fix typo * test whether removing kind from request works * revert removing kind from request * make kind read-only * run prettier * try adding properties to empty classes --------- Co-authored-by: Rajarshi Sarkar 🦄 <[email protected]> Co-authored-by: Rajarshi Sarkar <[email protected]> Co-authored-by: Liangying.Wei <[email protected]> * [OpenAI] Rename properties for Java (#24596) * renames * more renames * testing on the deploymentOrModelName * revert for no breaking changes * [TypeSpec] Upgrade to 0.46.0 (#24776) * [OpenAI] Update generated autorest (#24788) - Continuation of #24596 * Dynatrace.Observability merge to public repo (#24101) * Initial Commit * Updating version in all files * Removed version from readme * removing version which are not available from readme * Resolving PR comments (#24205) * Features/users/abhargava/merge to public repo (#24230) * Resolving PR comments * Features/users/abhargava/merge to public repo (#24233) * Resolving PR comments * Responding to the comment in PR review * Fixed typo * Features/users/abhargava/merge to public repo (#24253) * Resolving PR comments * Responding to the comment in PR review * Fixed typo * Added a suppression for Avacado issue * Adding the required field * Updating suppression reason * Updating path for suppression * Adding suppression for deprecated API * suppression * suppress * Update specification/dynatrace/resource-manager/readme.md Co-authored-by: Yuchao Yan <[email protected]> * updating path in suppression * updating suppression * updating suppression * Update specification/dynatrace/resource-manager/readme.md: WIP: fixing suppressions Iteratively work on fixing suppressions * Update readme.md: update suppressions * Update readme.md: update suppressions * Update readme.md: remove Avocado suppressions --------- Co-authored-by: kanupriyasinghh <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: Konrad Jamrozik <[email protected]> * Double Header Fix (#24760) * [OpenAI.Inference] Adding content filter support (#24652) * first-pass adding annotation * FilterResult definitions * move Filter definitions to common * cleaning up naming and imports * adding version headers * added descriptions to objects * correct self_harm JSON projection * Correct to "prompt_annotations" * "prompt_annotations" for chat, too * Update specification/cognitiveservices/OpenAI.Inference/models/completions.common.tsp Co-authored-by: Shawn Fang <[email protected]> * Add per-choice content_filter_results to /completions * tsp compile after merge * recompile with 0.46.0 after today's update --------- Co-authored-by: Travis Wilson <[email protected]> Co-authored-by: Shawn Fang <[email protected]> * Update OpenAI PR assignment (#24794) * Update OpenAI PR assignment * Update pull_request_assignment.yml * [typespec-ci] Automatically detect spec folders to validate (#24629) * [fist] mgmt, update service name (#24781) * [typespec-pr] Add pipeline (#24802) * [typespec-ci] Remove path wildcard (#24804) * Update engsys CODEOWNERS (#24808) * Align optionality of content filter categories (#24819) * Add spec ARM PR review workflow diagram to ARM PR description template. (#24823) * Add spec PR review workflow diagram to ARM PR description template. * Update control_plane_template.md: fix link to diagram (#24828) * Added generator config for OpenAI `Functions` for the Java SDK (#24765) * Remove repeatability support for token revocation endpoint (#24589) * Update clientTYpe (#24503) * [Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (#24048) * Revert "Revert "[Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (#23832)" (#23923)" This reverts commit e6c0e188a74d051a3a44728ce058e85447553392. * Removed 202 and Async supression. * Update documentation. * Updated documentation --------- Co-authored-by: Kalpesh Chavan <[email protected]> * [package-lock.json] Add names to local dependencies (#24846) - Command "npm update" removes these names, but "npm install" adds them - It's probably better to keep the names, since users are more likely to run "npm install" * Update ci-fix.md: add API Doc Preview TSG (#24843) * Update ci-fix.md: add API Doc Preview TSG * Remove unsupported SQL Pool Rename/move operation (#24517) * Updated text for property isSoftDeleteFeatureStateEditable (#24713) * Updating folder structure for Microsoft.Migrate (#24550) * folders restructure and update readme * revert removed offazure in readme * Removing readonly flag from top level object (#24848) * [ACS JobRouter] Add misssing descriptions (#24842) * Updated JR swagger with maxNumberOfJobs * sync with upstream main * add descriptions * prettier fix * add more missing descriptions * add more description fixes --------- Co-authored-by: williamzhao87 <[email protected]> * a couple of representation tweaks for codegen (#24847) * Removed FunctionDefinition as custom class (#24870) * Update readme.python.md (#24873) * Update readme.python.md * Update readme.python.md * add title in typescript.md (#24879) * Ericasp/number lookup preview (#24787) * add isoCountryCode field (#24223) * changed isoCountryCode description --------- Co-authored-by: Erica <[email protected]> Co-authored-by: Erica Sponsler <[email protected]> * Update communicationserviceschat.json (#24845) * update client name in typescript.md (#24894) * update sphere ts.md (#24895) * Convert previous preview version Private Link to GA: 2023-06-30 for mysql (#24738) * copy previous version as base for 2023-06-30 * update api version * update readme * fix arm id * Fixed code owner for NRP (#24889) * Synapse SDK release [2023-06] (#24908) * Anfranci/fixstartexectemplate2 (#24885) * fix start job exec template required property * fix start job exec template required property * fix start job exec template required property * SRP Swagger Updates for Jan23 [2023-01-01] Api Version GA (#23918) * Full copy from 2022-09-01 to 2023-01-01 without any changes * update examples api version, update swagger api version for each swagger, update readme files * Feature: AutoUptier for LCM with example * prettier check * Update new deafults for allowBlobPublicAccess and allowCrossTenantReplication * Feature: ObjectReplicationRestorePoint APIs with examples, validation and prettier check * Feature: Customer Initiated Migration with validation and prettier check * Feature: Planned Failover with validation and prettier check * Feature: BlobInventoryPolicyFilter creation time with validation and prettier check * Revert "Feature: ObjectReplicationRestorePoint APIs with examples, validation and prettier check" This reverts commit 6942ddfc948f9693cd04e4768a361a6ab0607332. * Address comments for autoUptier * address Migration comments * Update allowedMethods for CORS * Revert "Address comments for autoUptier" This reverts commit 5ac6d025ef1d2c5b5898f9e102d6f1cfa4271840. * Revert "Feature: AutoUptier for LCM with example" This reverts commit a1469d0b51914d11058e0cab8a7cc294e5aae761. * remove autoUptier example * targetSkuName description and migration name parameter * Remove Get customer initiated migration * Fix targetSkuName required property, fix typo * Address lint diff new errors * Add get migration back, fix uri for post migration * remove query parameter from post migration * Resolve Lint Diff errors * Spell Chek errors * Fix Post Migration example to return header --------- Co-authored-by: Udit Sharma <[email protected]> * [Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-06-01 (#24581) * Adds base for updating Microsoft.ContainerService/aks from version stable/2023-05-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Hobov2 Swagger (#24471) * Hobov2 Swagger * fix error * update python & java readmes (#24462) * Bring Node os upgrade channel up GA from preview except security patch (#24487) * bring nodeosimage up to GA except for security channel * Update managedClusters.json * add vpa (#24508) Co-authored-by: zhifanhui <[email protected]> * Allow user to specify draintimeout in ga api (#24488) --------- Co-authored-by: Xu Xue <[email protected]> Co-authored-by: Paul Miller <[email protected]> Co-authored-by: huizhifan <[email protected]> Co-authored-by: zhifanhui <[email protected]> Co-authored-by: Paul Miller <[email protected]> * Release network microsoft.network official 2023 04 01 2 (#24841) * Adds base for updating Microsoft.Network from version stable/2023-02-01 to version 2023-04-01 * Updates readme * Updates API version in new specs and examples * Double Header Fix (#24783) * Add Basic sku to applicationGateway.json (#24717) * Add http listeners alias to frontend ip config (#24718) * Sync mode property on Load balancer backend pool (#24685) * Sync mode property on Load balancer backend pool * model fix --------- Co-authored-by: unknown <[email protected]> * Migrate to IP based LB API change (#24633) * Migrate to IP based LB API change * Nit Fix * NIT Fix * Add body param pools * Param name update --------- Co-authored-by: unknown <[email protected]> --------- Co-authored-by: Mikhail <[email protected]> Co-authored-by: JainRah <[email protected]> Co-authored-by: russsantos <[email protected]> Co-authored-by: anjbal <[email protected]> Co-authored-by: unknown <[email protected]> * Adding new APIs for billing visibility in new version 2023-07-01-preview for Microsoft.Elastic (#24587) * Base API Commit * Changing API version to 2023-07-01-preview * Adding new apis for billing visibility * updating readme.md * added partnerEntityUri in the response * model validation fixed * taking parameters from v5 common types * [typespec-ci] Improve change detection (#24825) - Fixes #24813 - Fixes #24818 * [typespec - pr] Validate all specs if any changes to common files (#24826) - Fixes #24814 * [typespec-ci] Disable PR trigger (#24920) * Storage STG 90 (#24915) * Added new version of Data Lake swagger (#23905) * Added new Files swagger (#23907) * Paginated Directory Delete (#24146) * mgmt, java, azurestackhci, dedup name "Update" (#24924) * update parameter name in selfhelp sample (#24928) * Update TypeSpec get started guide (#24901) * Update TypeSpec get started guide * Update documentation/typespec-rest-api-dev-process.md Co-authored-by: Wes Haggard <[email protected]> --------- Co-authored-by: Wes Haggard <[email protected]> * [Hub Generated] Review request for Products to add version preview/2023-05-01-preview (#24678) * Adds base for updating Products from version preview/2023-01-01-preview to version 2023-05-01-preview * Updates readme * Updates API version in new specs and examples * 2023-05-01-preview version * fix locations * fix readme * fix validations 1 * fix RAM * Add has RI * Remove dynamic page size query param * Refactor operation id * Fix readme * Fix products operation id * Documentation fix 1 * Documentation fix 2 * Documentation fix 3 * spell check fixes * prettier fixes --------- Co-authored-by: Oren Kafka <[email protected]> * [Get-TypeSpec-Folders.ps1] Sort output alphabetically (#24932) * [Validate-TypeSpec.ps1] Add GitClean switch (#24933) - Continuation of #24629 * [Hub Generated] Publish private branch 'RPSaaSMaster' - NetworkCloud 2023-07-01 stable API (#24722) * add or modify files * removed non-published old private preview * New stable api 2023-04-01 Microsoft.RedHatOpenShift (#23772) * Previous API version * New API 2023-04-01 * Fix swagger linting error * Added xmsEnum for OutboundType * Re-word description for OutboundType * Microsoft.OperationalInsights: Correcting Total retention in days limitation. (#24574) * OperationalInsights: 2022-10-01 stable version * Actual changes. * More fixes. * more changes. * Removing redundant breaking change. * Workspace identity: referencing standard types. * Referencing managed identity standard type, refactoring booleans into enum. * Fixing examples. * Removing duplicate resource. * Update Workspaces.json * Update Clusters.json * Revert "Update Clusters.json" This reverts commit 4eb99cf4699afeb95dc2bab1ee071c7d4f9ee2c5. * Revert "Update Workspaces.json" This reverts commit c16bc82f2ec8a35131c1ec54d2dca147eca929d1. * Returning to our identity implementation. * OperationalInsights 2022-10-01: Changing retentionInDaysAsDefault to boolean representation. * redundant comma. * redundant comma. * Adding missing example header. * Update TablesDelete.json * Microsoft.OperationalInsights: Correcting Total retention in days limitation. * config reademe.go.md (#24941) * config reademe.go.md * format * [Hub Generated] Publish private branch 'main' (#23608) * add swagger * updated swagger * Updated readme for Unified Vision Service * fixed build error * update api version * fixed typo * update comment * Add examples * fixed * prettier * add custom word * Address some comments --------- Co-authored-by: KUAN LU <[email protected]> * Changing operation name to match other related API for documentation (#24588) * Update computeRPCommon.json (#24910) * add directive mobilenetwork reademe.go.md (#24942) * sql readme.go.md directive (#24610) * sql readme.go.md directive * rename to ServerPrivateEndpointConnectionProperties * lenient-model-deduplication * Saifahmed098 databoxedge microsoft.data box edge 2023 07 01 (#24926) * Adds base for updating Microsoft.DataBoxEdge from version stable/2022-03-01 to version 2023-07-01 * Updates readme * Updates API version in new specs and examples * Adding string KubernetesWorkloadProfile in databoxedgeProperties * Update readme.python.md (#24980) * Update readme.python.md * Update readme.python.md * [ACS - Call Automation] [Beta2] Api spec for 2023-06-15-preview (#24482) * Add beta2 api spec * add readme * fix lines * Fix readme * Added repeatability * Fix 202 long running * Fix header * Fix the base * Fix check * added x-ms-long-running-operation * add location * fix example * test * test * test * fix * test * fix test * test * Fix * test * test * fix * Remove LRO * Updates as per ARB feedback * Updates as per ARB feedback * Fix senddtmfTones * Fix error * Fix send dtmf description * Update/remove obsolete docs (#24946) * Add openapi docs for OpenAI api version 2023-07-01-preview (#24992) * rename EdgeZoneStorageAccountType back to StorageAccountType to avoid breaking (#24988) * Adding new optional parameter to Auto Patching (#24554) * [TypeSpec Validation] Get-TypeSpec-Folders.ps1 should only validate all specs on selected files (#25010) - Fixes #25006 * Update readme.python.md (#25009) * Update readme.python.md * Update readme.python.md * [Hub Generated] Review request for Products to add version preview/2023-05-01-preview (#25014) * Documentation fixes * Documentation fixes 2 * Documentation fixes 3 * Documentation fixes 4 * Documentation fixes 5 --------- Co-authored-by: Oren Kafka <[email protected]> * fix enum mismatch (#24559) * Moving Markup rules API into separate file (#25003) * [ACS Chat] [Rest API] Added chat thread metadata and participant meta… (#24837) * [ACS Chat] [Rest API] Added chat thread metadata and participant metadata. (#24243) * Updating ACS Chat swagger with Chat thread and participant metadata. * Fixed swagger version. * Fixed swagger version. * Re-added data retention policy to the swagger. * Update communicationserviceschat.json - changed metadata from string to dictionary * Update communicationserviceschat.json * Update communicationserviceschat.json Corrected size limitations - should be 1k, not 2k * Update communicationserviceschat.json Added metadata to patch thread request * Update communicationserviceschat.json --------- Co-authored-by: Andrei Giurgiu <[email protected]> * remove data retention from 2023-07-01 --------- Co-authored-by: Andrei Giurgiu <[email protected]> Co-authored-by: Lu Chen <[email protected]> * Added missing ArchiveStatus value (#25024) * Update PrivateEndpointConnections to 2022-11-01-preview in v5 SDK (#25015) * sql readme.go.md directive (#25029) * sql readme.go.md directive * fix * [TypeSpec Validation] Rename yml files to match pipelines (#25036) * Update readme.python.md (#25035) * Disable creation of perimeter base rule (#24945) * Disable creation of perimeter base rule * Made NSP rule readonly * Added email/sms rule changes * Minor fix * [Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-06-02-preview (#24922) * Adds base for updating Microsoft.ContainerService/aks from version preview/2023-05-02-preview to version 2023-06-02-preview * Updates readme * Updates API version in new specs and examples * Hobov2 Change Swagger Preview (#24472) * Hobov2 Swagger * fix error * Add SSHAccess property to agent pool (#24460) * Add SSHAccess property to agent pool * add new line * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: FumingZhang <[email protected]> --------- Co-authored-by: FumingZhang <[email protected]> * update python & java readmes (#24461) * Image Integrity swagger in 20203-06-02-preview (#24454) * Image Integrity swagger in 20203-060-20-preview * f * f * ff --------- Co-authored-by: fseldow <[email protected]> * Azure Service Mesh - BYO CA, Egress Gateway and Mesh Revisions (#24453) * Azure Service Mesh - BYO CA and Egress Gateway * prettier fix. * adding changes for for revisions and meshversioncompatibilityprofile * adding a missing parameter * Changes as per lint failures * Mikolaj/add custom node config 2023 06 02 preview (#24539) * feat: add Ulimit config and updated sysctl ranges to swagger * fix: use ulimits in json of LinuxOSConfig * feat: add response example * fix: add ulimits to custom words * Revert "fix: add ulimits to custom words" This reverts commit 949673772bb77447d5b3975ea5da27767c9705e2. --------- Co-authored-by: Mikolaj Umanski <[email protected]> * add Drain Timeout in preview (#24579) Co-authored-by: Wenjun Gao <[email protected]> * fix: remove ulimits from swagger spec (#24921) Co-authored-by: Mikolaj Umanski <[email protected]> * address ARM review comments (#25005) * address ARM review comments * added a missing description. * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <[email protected]> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <[email protected]> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <[email protected]> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <[email protected]> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <[email protected]> * Update specification/containerservice/resource-manager/Microsoft.ContainerService/aks/preview/2023-06-02-preview/managedClusters.json Co-authored-by: Sanya Kochhar <[email protected]> --------- Co-authored-by: Sanya Kochhar <[email protected]> --------- Co-authored-by: Xu Xue <[email protected]> Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Xinhe Li <[email protected]> Co-authored-by: fseldow <[email protected]> Co-authored-by: deveshdama <[email protected]> Co-authored-by: Mikołaj Umański <[email protected]> Co-authored-by: Mikolaj Umanski <[email protected]> Co-authored-by: Wenjun Gao <[email protected]> Co-authored-by: Wenjun Gao <[email protected]> Co-authored-by: Sanya Kochhar <[email protected]> * [Hub Generated] Add new api version 2023-05-01 for Microsoft.App (#24939) * Adds base for updating Microsoft.App from version preview/2023-04-01-preview to version 2023-05-01 * Updates readme * Updates API version in new specs and examples * Revert AppGw HttpListeners alias change (#24966) * [Hub Generated] Review request for Microsoft.ContainerRegistry to add version preview/2023-06-01-preview (#24426) * Adds base for updating Microsoft.ContainerRegistry from version preview/2023-01-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * Added new api version 2023-06-01-preview * Fixed examples * Fixed Prettier check. * Fix lint error. * fix pretty print * Try fix avacodo error * Fix the default tag * add directive in readme.go.md --------- Co-authored-by: Alancere <[email protected]> * [Hub Generated] Publish private branch 'u/michaelshikh/azure-kusto-Microsoft.Kusto-2023-05-02' (#24964) * kusto 2023-05-02 fix "final-state-via" header * take 2 * remove "x-ms-long-running-operation-options" * remove "x-ms-long-running-operation-options" * Release sentinel 2023 07 01 preview (#24557) * Adds base for updating Microsoft.SecurityInsights from version preview/2023-06-01-preview to version 2023-07-01-preview * Updates readme * Updates API version in new specs and examples * Added Approved and Backlog to Hunts Status enum (#24552) * [Sentinel] [New Public API] Add swagger doc for dataConnectorDefinition API (#24509) * add dataConnectorDefinition API doc * update examples * add pattern * update pattern * update pattern * update description * update description * small fix * small fix * small fix * small fix * update swagger document based on feedback from the SDK team (#24555) * Fix dataConnectorDefinition (new API) (#24759) * fix swagger doc * typo * fix int format * Fix pattern (#24807) * remove pattern * add and fix - reuired parameter in the new validation * add and fix - reuired parameter in the new validation * fix pattren * fix pattren * Remove CloudError.cs file (#24962) Remove CloudError.cs. Added by mistake in https://github.com/Azure/azure-rest-api-specs/pull/24807/files * Add pagination (#24986) * add pagination --------- Co-authored-by: artafres <[email protected]> Co-authored-by: sagamzu <[email protected]> * Update documentation for Cost Details to specify Resource group and management group is not supported (#24844) * Update readme.python.md (#25055) * [Hub Generated] Review request for Microsoft.Management to add version stable/2023-04-01 (#24976) * Adds base for updating Microsoft.Management from version stable/2021-04-01 to version 2023-04-01 * Updates readme * Updates API version in new specs and examples * [Hub Generated] Review request for Microsoft.LabServices to add version stable/2023-06-07 (#24981) * Adds base for updating Microsoft.LabServices from version stable/2022-08-01 to version 2023-06-07 * Updates readme * Updates API version in new specs and examples * added v2023-06-07 spec * reset clouderror change * update version date * updated times * fix times in examples * update inviteuser example * reinclude x-mx-identifiers * Update for Swagger PrettierCheck * TLS Default version updated to enforce TLS 1.2 (#24440) Co-authored-by: Daniel Salazar Mora <[email protected]> * Update the ARM spec PR review workflow diagram (#25071) * update python config (#25074) * Add MicrosoftProduct to ProductType enum (#25046) Co-authored-by: Oren Kafka <[email protected]> * Initial version of the code-signing dataplane service (#22310) * Initial version of the code-signing dataplane service * Remove error objects since those come from the Azure Core namespace * fix: added azure.codesigning.json resulting file * fix: use newer version dependency syntax * Rolling back version change per PR feedback * fix: polling operation mapping per PR feedback * Adding x-ms-examples for example validation * fix: added custom-words per PR feedback * Renamed parameter definition to match open api json definition * fix: modified the api-version to synch up with the folder api-version * Adding details json cadl validation * refactor: moved from cadl to typespec * chore: attach azure.codesiging.json definition * chore: remove package-lock.json since its unneeded. * feat: adding get sign eku operation & example fix: sign long running operation * chore: removed unused swagger.json generated * chore: removing data-plane swagger generated, keeping just the typespec project * Readding the swagger information for dataplane service * fix: ci issues pointed examples are not referenced on the swagger file resources should not be read only * added examples to typespec definition * fix: examples * more fixes for example.json operations * even more fixes for example.json operations * fix: minor Remove optional parameter from region. since its required. Added description to namespace definition Removed optional parameter from operation status, since the id is required. Added suppression of warning * Added fixes to azure.codesigning.json generation * Added required property of id to examples * Switched property to a more descriptive naming for the eku response * fix: moved examples to a non version specific folder * fix: the compiler didnt liked not using the preview folder, rolling back * feat: added oauth2 security definition * fix: removed api-version from example path * style: change casing of operations to camel case fix: per guidance modified the getsignEku operation into listSignEku * Update azure.codesigning.json generated by tsp compiler * fix: modified ResourceAction to LongRunningResourceAction per feedback * docs: added enum descriptions to each value on hash algorithms * fix: pinned to current versions to avoid ci errors by using latest dependency * Added prefix of StandardResourceOperations interface to Resource operations * fix: sign operation should return 202 Accepted on example * fix: sign operation should return 202 Accepted on example * style: tsp format result * refactor: removed unused mapping to parent resource * refactor: removing typespec-python emitter * Adding get sign root certificate operation * fix: adding custom word rootcert * fix: adding api version parameter * Added resource provider folder per ci finding * chore: removing package.json per PR feedback * Renaming folder to remove "Microsoft." path per feedback from PR see: https://github.com/Azure/azure-rest-api-specs/blob/main/documentation/typespec-structure-guidelines.md for guidelines * feat: expanded the typespec options to include the lang generation * Fix: Based on review from API stewardship team Added more detailed information for docs and summary of operations Refactored getSignRootCertificate operation to use RpcOperation instead of custom operation Pluralized the listSignEkus operation Renamed models to provide more detailed description of their purposed Eliminated the custom enum in favor of the typespec enum provided * refactor: moved version to 2023-06-15 based on feedback of ACS Eng team * refactor: renamed models following azure team feedback * Update tspconfig.yaml Applied latest schema of emitter options and parameters. * fix: adding back missing custom words, fixing coffeelake casing * docs: updated samples to include varied hashes to represent a more familiar request for customers * docs: updated the docs clauses of the typespec file to avoid repetitions on the docs generated. * fix: update README.md of data-plane generation to include the correct tag * Regenerated azure.codesigning.json file * Based on pr build feedback, updated custom words definition * docs: per compiler feedback, adding doc definition for versioning * fix: outdated examples of data-plane swagger * fix: per PR feedback, using T payload for Foundations.OperationStatus * chore: updated Azure.CodeSigning swagger generated using tsp v0.46.0 * fix: removed autorest from the dependencies per feedback fix: added suppression for custom RPC operation * Removing json examples for compliance with avocado pipeline * fix: Adding examples to tsp directory * Corrected samples --------- Co-authored-by: Ray Chen <[email protected]> * [Bug-Fix] Minor change in Managed Network Fabric (#24948) * Changes Made: 1. InternetGateways - type param is renamed to gatewayType 2. NetworkFabricSkus - type param is renamed to skuType 3. AccessControlLists: -> action -> type is renamed to actionType -> matchcondition -> ipmatchCondition -> type is renamed to ipType 4. NetworkTapRule -> action -> type is renamed to actionType -> matchcondition -> ipmatchCondition -> type is renamed to ipType New Params: 1. In RoutePolicies: -> statements -> defaultAction [Permit | Deny -> default Deny] is added. 2. In RoutePolicy -> condition -> conditionType is added. 3. In AccessControlLists: -> matchConfiguration -> defaultAction [Permit | Deny -> default Permit] is added. * Reverting the changes made for "type" parameter. * Add Microsoft.StorageTasks Service | Swagger API Review (Ring 0 Service) (#24798) * Add the Readme files and StorageTasks Spec file with CRUD and List by subs and rg with examples * Rectify provider namespace to Microsoft.StorageTask and refactor examples into folders * Address Lint diff failure to use the model from common-types * Update Operations API with defaut response * Add List Storage Task Assignment ARM Ids API * Add POST List Storage Task Run Report Summary API * Adding x-ms-identifiers * Spell corrections * Fix spell check errors * Add 201 response code to PUT task operation * Address minor changes and comments to reuse existing schema, update examples * Add request body to List Summary Report API, Add Example. Remove 200 status code from Delete Async * Add example reference to API file * Adding Storage task action preview API with example * Correct spelling * Addig allowed resource type constraint * Change the Reporting API to GET with Arm resource type Microsoft.StorageTasks/storageTasks/reports * Address PR comments, correct and rephrease operation ids * Change to proxy resource * Fix typo * Better instructions in footnotes for the ARM spec PR review workflow diagram (#25076) * Updated request models for R2026 issue agrifood microsoft.ag food platform 2023-06-01-preview (#25057) * Adds base for updating Microsoft.AgFoodPlatform from version preview/2021-09-01-preview to version 2023-06-01-preview * Updates readme * Updates API version in new specs and examples * Rename changes + Control Plane BYOL changes * added examples * added examples for data Connector Apis * fixing lint issues * reorder and updated description * node description updated. * updated like Solution Apis * beautify json examples * prettier fix * custom words + spelling fix * system data lower case * removed dataConnectorName from example + lint fix * fixed lint issue in example * prettier fix * Default Error response + 201 code * Description updated * request model made same as response in patch * added status code 201 in PUT API * updated solution example * updated changes for OAuth renaming * updated Data Connector examples * example update * corrected typo * syncing to latest DI Agri branch * added MADMA in custom-words file * data connector delete example updated * solution example updated * xms error fix * added xms-identifier * fixing examples * updated create or update example * prettier fix * solution fix * updated examples * prettier fix * lint issue fix * fixing lint diff --------- Co-authored-by: Abhishek Khatri <[email protected]> * privateEndpointConnections and privateLinkServiceConnectionState naming fixes (#24810) * Add comment handler for /pr RequestMerge (#25091) * Sync expression Support From DataFactory To Synapse (#25054) * Sync expression Support From DataFactory To Synapse * add * Update the ARM PR workflow diagram to use the `/pr RequestMerge` guidance. (#25093) * Improve ARM PR template and guidance around breaking changes (#25086) * [Hub Generated] Review request for Microsoft.Maps to add version stable/2023-06-01 (#23862) * Adds base for updating Microsoft.Maps from version preview/2021-12-01-preview to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * updates to schema * move to v4 as managedidentity is broken in v5 * fixes from build * fix example * reuse trackedresource v2 * adding suppression for move * trying to suppress with from * attempt 3 for supression based on cogsearch * Updating ContainerStorage Swagger (#24749) * updating containerstorage to match Azure-ContainerStorageRP swagger * updating readme.md files * removing disks in example request and adding an extra zone to examples * updating examples * Add new API version 2023-03-01 for databox (#24857) * initial commit - previous version * add new version * add new version in readme * fix validation checks * fix readme file --------- Co-authored-by: Uttaran Sarkar <[email protected]> * Update readme.python.md (#25136) * [package.json] Remove cadl packages (#25141) - Any specs still using Cadl must upgrade on next change - Fixes #25126 * Add ConfiguringAAD as a provisioning state (#25079) Co-authored-by: Kanchan Joshi <[email protected]> * [CODEOWNERS] Add selected root files to EngSys (#25143) * [HDInsight][Hilo]Add new APIs (#24940) * Add new APIs * Fix spell, modelvalidation and avocado errors * fix false alarm linting error * Fix linting error * Add readme files under hdinsightonaks folder * Update json file path * Update readme.python.md * a) update job related definition b) update some resource id property to use c) update key vault object type as enum * mark cluster pool compute profile count as readonly * remove wrong avocado suppress fro readme.md per comment --------- Co-authored-by: Zhenyu Zhou <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * [TypeSpec Validation] Trigger on PRs to all branches (#25174) * Add missing space (#25153) Co-authored-by: Oren Kafka <[email protected]> * Added lro-options for dataprotection 2023-01-01, 2023-05-01 (#24715) Co-authored-by: Vishesh Patel <[email protected]> * TypeSpec Getting Started doc (#25021) * TSP Getting Started * update * updated doc * updated doc * moved how to create PR from TypeSpec doc to rest-api-spec repo * updated per PR comment * AVS API 2023-03-01 (#24490) * cp -r 2022-05-01 2023-03-01 * set version as 2023-03-01 * changes * switch back to v1 ErrorResponse * must not use two differert ErrorResponse types * use v5 ErrorResponse (#4) * remove sku changes * #/definitions/Sku * remove old readme block * remove skus.json * add patterns for resource names ported from https://github.com/Azure/azure-rest-api-specs-pr/pull/11127 * Update readme.python.md (#25195) * Update readme.python.md (#25078) * Update readme.python.md * Update readme.python.md * [Hub Generated] Review request for Microsoft.HybridCompute to remove version preview/2023-04-25-preview (#24970) * update name pattern and change instanceview * update examples * add ExtensionsResourceInstanceView * change extensions instance view * undo ref change * update times in examples * Remove 04-25-2024 from the public specs repo. Will add these specs to the private repo * Update readme.md * Update readme.md --------- Co-authored-by: Ved Kale <[email protected]> * [Compute] New API Version 2023-04-02 (#25118) * adding new folder 2023-04-02 * readme section for 2023-04-02 * changing version number in folder 2023-04-02 * Adding new disk property - LastOwnershipUpdateTime (#25039) * Added lastownership field * Added to existing DIsk_Get.json example * Swagger changes for elastic san import and export feature (#24953) * swagger changes for elastic san import and export feature * fixing API version in swagger examples * adding reference to examples * fixing examples * Dev/carloshehe/last ownership update time (#25160) * Added lastownership field * Added to existing DIsk_Get.json example * New description * Using Vikram's suggestion for description * Fixed bad casing --------- Co-authored-by: carlos6125 <[email protected]> Co-authored-by: PrambMS <[email protected]> * New AO5GC 1.0 service - 2023-05-15-preview (#24950) * New AO5GC 1.0 service - 2023-05-15-preview * Addressed the Swagger LintDiff errors * Addressed the Swagger ModelValidation errors * Addressed long running operation LintDiff errors * Formatted the *.tsp files * Removed the common.json and added the parameters to the networkfunction.json * Updated the Type Script to address the Swagger API validations * Addressed the validation errors * Updated the examples and formatted the *.tsp files * Update specification/mpcnetworkfunction/resource-manager/readme.typescript.md Co-authored-by: Qiaoqiao Zhang <[email protected]> * Update specification/mpcnetworkfunction/mpcnetworkfunction.Management/tspconfig.yaml Co-authored-by: Mike Harder <[email protected]> * Updated the common types version to v3 * Updated the networkfunction TypeSpec file to the latest version and generated the Swagger API --------- Co-authored-by: Qiaoqiao Zhang <[email protected]> Co-authored-by: Mike Harder <[email protected]> * [Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-07-01 (#25151) * Adds base for updating Microsoft.ContainerService/aks from version stable/2023-06-01 to version 2023-07-01 * Updates readme * Updates API version in new specs and examples * feat: add range min/max for custom node config GA changes for 2023-07-01 API (#25068) Co-authored-by: Mikolaj Umanski <[email protected]> * update readmes (#25048) * add force upgrade option (#25100) * add force upgrade option * update msg --------- Co-authored-by: Wenjun Gao <[email protected]> --------- Co-authored-by: Mikołaj Umański <[email protected]> Co-authored-by: Mikolaj Umanski <[email protected]> Co-authored-by: Wenjun Gao <[email protected]> Co-authored-by: Wenjun Gao <[email protected]> * [TypeSpec Validation] Only validate all specs on core PRs to public repo (#25207) - Fixes #25175 * Use unix line endings always, even on Windows (#24817) - Fixes #24791 - Fixes #24790 - Ensures developers can successfully work on both Linux and Windows - Consistent with other repos like `microsoft/typespec` and `azure/azure-sdk-for-js` - Required for node-based tools like `tsp format` which assume LF * Synapse change sessionId type from int to string (#25210) * change sessionId type from int to string * modify related code * [TypeSpec] Upgrade to 0.47.0 (#25223) * Renormalize line endings from CRLF to LF (#25219) - Fixes #25212 - Files were committed with CRLF instead of LF - Should be prevented going forward due to settings in `.gitattributes`, but clients can always force add files with CRLF - Related to #24817 - Issue seen before in #4746 and #3786 * config readme.go.md (#25227) * July 2023 API Version for Azure Data Manager for Agriculture (#24755) * added july 2023 api version * fixed few changes * Prettier * Avocado * Updated examples * fixed examples * added changes * addressed review comments * addressed review comment * fixed build issue * fixed model validation error * addressed comment * addressed review comments * few minor changes * added minor changes * prettier * addressed review comments * `securitycenter`: fix yaml (#24619) * `securitycenter` fix yaml * fix path in readme.md * remove kubevirt and openstanck (#25094) * [AutoSync] db0c25231 Merged PR 8381862: update manifest (#25034) Co-authored-by: swagger-automation <[email protected]> * [Hub Generated] Review request for Microsoft.DesktopVirtualization to add version preview/2023-07-07-preview (#24747) * Adds base for updating Microsoft.DesktopVirtualization from version preview/2022-10-14-preview to version 2023-07-07-preview * Updates readme * Updates API version in new specs and examples * Added ScalingPlanPersonalSchedule examples to Examples * Added scalingPlanPooledSchedule endpoints to swagger * Added flexAppGroup to public preview * Added scalingplanpersonalschedules endpoint to proper swagger version * Added showInFeed property to correct swagger version * Added missing scaling plan personal schedule * Added pattern * Removing pattern restriction as it causes breaking changes * Corrected api version in example * change new scaling API to use v3 common types * Added pattern * Removed pattern and added suppression. * Revert "change new scaling API to use v3 common types" This reverts commit a169c4031f253b54172a4b5271f0f8290db8d7de. --------- Co-authored-by: Dallin Magleby <[email protected]> * CRP 2023 07 01 version (#25066) * add new folder * update readme * update version reference in swagger files * psuh * revert last commit * Add missing parameter(timeCreated) in VMSS VM (#23848) * Updating examples for GetImages API to add details about paging.. (#24030) * Updating examples for GetImages API to include the paging support. * Addressing PR comments. Added the a template for next link --------- Co-authored-by: Naveena Patil <[email protected]> * Add optional parameter domain name label scope to VM and VMSS PIP dnsSettings (#24329) * add optinal parameter domain name label to vm and vmss pip dnssettings * fix syntax * fix syntax * fix syntax * changes made by prettier * Update Image_ListBySubscription.json prettier * update diskRP reference to latest. Merge conflict. * credscan remediation * Adding support for Sirius on VMSS (#25117) * adding auxmode and auxsku * adding example --------- Co-authored-by: Prachi Pravin Bhavsar <[email protected]> * missed ticks from conflict merge --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: payalguptapg <[email protected]> Co-authored-by: nreact <[email protected]> Co-authored-by: Naveena Patil <[email protected]> Co-authored-by: tinama0302 <[email protected]> Co-authored-by: pracsb <[email protected]> Co-authored-by: Prachi Pravin Bhavsar <[email protected]> * Update control_plane_template.md: update merge queues links (#25231) * Added artifactType query param to listkeys route (#24868) Co-authored-by: Sai Sankar Gochhayat <[email protected]> * [Hub Generated] Review request for Microsoft.ConnectedVMwarevSphere to add version preview/2023-03-01-preview (#25147) * Adds base for updating Microsoft.ConnectedVMwarevSphere from version preview/2022-07-15-preview to version 2023-03-01-preview * Updates readme * Updates API version in new specs and examples * Merging new API version from private pr repo https://github.com/Azure/azure-rest-api-specs-pr/blob/RPSaaSMaster/specification/connectedvmware/resource-manager/Microsoft.ConnectedVMwarevSphere/preview/2023-03-01-preview * fix lint errors * fix json * fix more lint errors. * update * update * fix lint errors * prettier and fix examples. * fix quotes. * Release microsoft.app 2023 05 02 preview (#25051) * Adds base for updating Microsoft.App from version preview/2023-04-01-preview to version 2023-05-02-preview * Updates readme * Updates API version in new specs and examples * fix description for endTime in JobExecution (#24359) * fix description for endTime in JobExecution * fix for breaking change error * Introduce Microsoft.App/builders tracked resource and Microsoft.App/builds proxy resource (#24240) * cherry picked commit to introduce builders and builds, and updated api version * added linting suppressions to readme * pre feedback: v3 -> v5, common build/er params, rename identity to identityresourceid, inprogress -> creating * fix typo * fix model validation * added updating provisioning status, and fixed a missed provisioning status ref * Create identity to registry mapping in builder object (#24275) * create identity to registry mapping in builder object * update mapping to be a dictionary of container registries, to enforce single container registry * run prettier * run prettier on examples fil * pr feedback: v5 -> v3 and added x ms param location * fix plural naming to singular * Add GetVerificationId API (#24286) * add api * fix typo * fix spacing * fix spacing * change version --------- Co-authored-by: Chenghui Yu <[email protected]> * Support multiple port for container app (#24332) (#24459) * Support multiple port for container app * lint * comment * Add blob storage token store support (#24455) * add blob storage token store support * update * update trigger type enum - schedule for jobs (#24399) * update trigger type enum - schedule for jobs * update trigger type enum - schedule for jobs * add previous changes merged to main * add encryption settings (#24822) * rename verification id to custom domain verification id (#24874) Co-authored-by: Chenghui Yu <[email protected]> * Removed SourceToCloud feature from 2023-05-02-preview (#24860) * Anfranci/fixstartexectemplateabv0423 (#24863) * fix start job exec template required property * fix start job exec template required property * fix start job exec template required property * fix start job exec template required property * Add list usages api for Microsoft.App (#24833) * add api * update * update * update * update * empty line --------- Co-authored-by: Paul Dorsch <[email protected]> Co-authored-by: anandanthony <[email protected]> Co-authored-by: Seris370 <[email protected]> Co-authored-by: Chenghui Yu <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: njucz <[email protected]> Co-authored-by: Xingjian Wang <[email protected]> * add dbName as required for spark metastore (#25259) Co-authored-by: Zhenyu Zhou <[email protected]> * the java sdk doesn't use that config (#25214) Co-authored-by: Zhenyu Zhou <[email protected]> * Alprosms cost management microsoft.cost management 2023 08 01 (#25065) * Adds base for updating Microsoft.CostManagement from version stable/2023-03-01 to version 2023-08-01 * Updates readme * Updates API version in new specs and examples * Adding GA for ReservationUtilization Budgets from version 2023-04-01-preview * updating swagger spec to new api version * adding x-ms-parameter-method property to budgetCategoryFilterParameter * Release keyvault mi…
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Oct 4, 2023
Release machinelearningservices microsoft.machine learning services 2023 08 01 preview (Azure#24762) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-06-01-preview to version 2023-08-01-preview * Updates readme * Updates API version in new specs and examples * MFE 2023-08-01-preview mfe.json (Azure#24764) * add mfe.json * labeling jobs update descriptions * add examples for ServerlessEndpoint * update labelingjob examples * label job examples remove additional properties * adding sku to patch * add identity to patch * add in operationresult to examples --------- Co-authored-by: Kayla Ames <[email protected]> * Adding Resources at sweep level (Azure#25090) Co-authored-by: Anubha98 <[email protected]> * HoboVM Preview Features (Azure#24769) * Update Pricesheet properties for savingsPlan (Azure#24708) * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update PriceSheet.json * Update consumption.json * Update consumption.json * Update consumption.json * Update PriceSheet.json * elasticsan preview refresh microsoft.elasticsan 2022-12-01-preview (Azure#24494) * Adds base for updating Microsoft.ElasticSan from version preview/2021-11-20-preview to version 2022-12-01-preview * Updates readme * Updates API version in new specs and examples * Added PE related changes * Added Private Link resource API * Nit change to correct the path for privateLinkResource API * Updated Lint errors * prettier check * resolved comments & added publicNetworkAccess * removed publicNetworkAccess & NIT changes * Updated the list operations * resolved lintDiff * proper value for examples and removed value from PECollections * resolved comments * spell check resolved * removing volumeCreateParameter * [Hub Generated] Publish private branch 'InbalZim-storagemover-Microsoft.StorageMover-RPSaaSMaster-2023-07-01-preview' (Azure#24390) * add or modify files * Updated `credentials` models according to PR Azure#24318 + reverted unwanted changes to `readme.md` * Removed URI format from SMB credentials to support it receiving empty string in order to clean-up their value * Removed extra hierarchy of `AzureStorageFileShareEndpointBaseProperties` * improve NR Examples (Azure#24636) * improve NR Examples * addressing AutoRun Errors * Fixing Prettier Issue * Adding NextLink in Max Examples * Formatting Azure Resource Id * Updating Format of azure subscriptionIds * update code owner (Azure#24754) * Update readme.python.md (Azure#24758) * [TypeSpecValidation] Refactor package.json (Azure#24756) - Improves upon Azure#24745 - Creates eng/tools/package.json for all EngSys tools - Moves "postinstall" to eng/tools/TypeSpecValidation/package.json - Technically incorrect if the package were ever to be published to a registry - In practice, the best way I have found so far to use source-based tools in a TypeScript repo * Add resize APIs * workflow-bot comments: update breaking changes alternative C to point to alternative B (Azure#24770) * Add properties for os patching (Azure#24775) Co-authored-by: Chris Jiang <[email protected]> * [Communication] Job Router Public Preview v2022-07-18 (Azure#23804) * Updated JR swagger with maxNumberOfJobs * job scheduling swagger changes * Enforce DistributionMode.kind to be read-only * retry with removing Required tag from abstract property for DistributionMode * WorkerState stopped showing up in generated swagger * Add reofferTimeUtc to decline offer API * Prettier * Prettier * rename WorkerState to RouterWorkerState * more fixes in polymorphic types * Rename decline offer request * prettier fix * add example for scheduled job * cpsell fix * fix response schema validation error * address review feedback item round 1 * SDK review changes * More API changes * Update distribution mode required properties * Renamings * job matching mode added * prettier fixes * fix examples refs * update ref examples * update swagger spec * fix enum mismatch * change operator to labelOperator in classification policy get and update ops example * Update specification/communication/data-plane/JobRouter/preview/2022-07-18-preview/communicationservicejobrouter.json Co-authored-by: Liangying.Wei <[email protected]> * hide redundant communicationerror and communicationerrorresponse during codegen * revert commit * fix typo * test whether removing kind from request works * revert removing kind from request * make kind read-only * run prettier * try adding properties to empty classes --------- Co-authored-by: Rajarshi Sarkar 🦄 <[email protected]> Co-authored-by: Rajarshi Sarkar <[email protected]> Co-authored-by: Liangying.Wei <[email protected]> * [OpenAI] Rename properties for Java (Azure#24596) * renames * more renames * testing on the deploymentOrModelName * revert for no breaking changes * [TypeSpec] Upgrade to 0.46.0 (Azure#24776) * Release quota on stop (Azure#24778) * Release quota on stop * add ReleaseQuotaOnStop to computeinstance properties * update * rm * [OpenAI] Update generated autorest (Azure#24788) - Continuation of Azure#24596 * Dynatrace.Observability merge to public repo (Azure#24101) * Initial Commit * Updating version in all files * Removed version from readme * removing version which are not available from readme * Resolving PR comments (Azure#24205) * Features/users/abhargava/merge to public repo (Azure#24230) * Resolving PR comments * Features/users/abhargava/merge to public repo (Azure#24233) * Resolving PR comments * Responding to the comment in PR review * Fixed typo * Features/users/abhargava/merge to public repo (Azure#24253) * Resolving PR comments * Responding to the comment in PR review * Fixed typo * Added a suppression for Avacado issue * Adding the required field * Updating suppression reason * Updating path for suppression * Adding suppression for deprecated API * suppression * suppress * Update specification/dynatrace/resource-manager/readme.md Co-authored-by: Yuchao Yan <[email protected]> * updating path in suppression * updating suppression * updating suppression * Update specification/dynatrace/resource-manager/readme.md: WIP: fixing suppressions Iteratively work on fixing suppressions * Update readme.md: update suppressions * Update readme.md: update suppressions * Update readme.md: remove Avocado suppressions --------- Co-authored-by: kanupriyasinghh <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: Konrad Jamrozik <[email protected]> * Double Header Fix (Azure#24760) * [OpenAI.Inference] Adding content filter support (Azure#24652) * first-pass adding annotation * FilterResult definitions * move Filter definitions to common * cleaning up naming and imports * adding version headers * added descriptions to objects * correct self_harm JSON projection * Correct to "prompt_annotations" * "prompt_annotations" for chat, too * Update specification/cognitiveservices/OpenAI.Inference/models/completions.common.tsp Co-authored-by: Shawn Fang <[email protected]> * Add per-choice content_filter_results to /completions * tsp compile after merge * recompile with 0.46.0 after today's update --------- Co-authored-by: Travis Wilson <[email protected]> Co-authored-by: Shawn Fang <[email protected]> * Update OpenAI PR assignment (Azure#24794) * Update OpenAI PR assignment * Update pull_request_assignment.yml * [typespec-ci] Automatically detect spec folders to validate (Azure#24629) * [fist] mgmt, update service name (Azure#24781) * [typespec-pr] Add pipeline (Azure#24802) * [typespec-ci] Remove path wildcard (Azure#24804) * Update engsys CODEOWNERS (Azure#24808) * Align optionality of content filter categories (Azure#24819) * Add spec ARM PR review workflow diagram to ARM PR description template. (Azure#24823) * Add spec PR review workflow diagram to ARM PR description template. * Update control_plane_template.md: fix link to diagram (Azure#24828) * Added generator config for OpenAI `Functions` for the Java SDK (Azure#24765) * Remove repeatability support for token revocation endpoint (Azure#24589) * Update clientTYpe (Azure#24503) * [Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (Azure#24048) * Revert "Revert "[Hub Generated] Publish private branch 'dev-maintenance-Microsoft.Maintenance-2023-04-01' (Azure#23832)" (Azure#23923)" This reverts commit e6c0e188a74d051a3a44728ce058e85447553392. * Removed 202 and Async supression. * Update documentation. * Updated documentation --------- Co-authored-by: Kalpesh Chavan <[email protected]> * [package-lock.json] Add names to local dependencies (Azure#24846) - Command "npm update" removes these names, but "npm install" adds them - It's probably better to keep the names, since users are more likely to run "npm install" * Update ci-fix.md: add API Doc Preview TSG (Azure#24843) * Update ci-fix.md: add API Doc Preview TSG * Remove unsupported SQL Pool Rename/move operation (Azure#24517) * Add enableOSPatching and address comments (Azure#24849) * Updated text for property isSoftDeleteFeatureStateEditable (Azure#24713) * Updating folder structure for Microsoft.Migrate (Azure#24550) * folders restructure and update readme * revert removed offazure in readme * Removing readonly flag from top level object (Azure#24848) * [ACS JobRouter] Add misssing descriptions (Azure#24842) * Updated JR swagger with maxNumberOfJobs * sync with upstream main * add descriptions * prettier fix * add more missing descriptions * add more description fixes --------- Co-authored-by: williamzhao87 <[email protected]> * a couple of representation tweaks for codegen (Azure#24847) * Removed pricing not relevant to CI * Added Resizing state * Change targetVMSize name * Revert "Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs into teom-hobovm08-01-preview" This reverts commit 47adff637482e53956bcde7a4331f0638a1ddfbc, reversing changes made to 4b9165da959a09109ecf96e7e70a940ec3989732. * Resolve comments for os patching (Azure#24872) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property --------- Co-authored-by: Chris Jiang <[email protected]> * Rename osPatchingStatus to upper case (Azure#24954) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property * Change property osPatchingStatus to upper case * rename osPatchingStatus to upper case --------- Co-authored-by: Chris Jiang <[email protected]> * Fix some minor issues * Fix comments * Minor changes * Fix more builds * 200 and nextLink * Remove nextlink * Try 204 not 200 * Change GET call to POST * Remove 204 * Add 200 response * Change example state * Add enum for patch status (Azure#25208) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property * Change property osPatchingStatus to upper case * rename osPatchingStatus to upper case * add enum for patch status * add enum for patch status --------- Co-authored-by: Chris Jiang <[email protected]> * LRO does not return 200 * Format readme * Format readme * Format readme * Fix readme * Rename enum for patchStatus (Azure#25257) * Add properties for os patching * resolve comments * remove autorestartafterupdates * update description * rename property * Change property osPatchingStatus to upper case * rename osPatchingStatus to upper case * add enum for patch status * add enum for patch status * rename enum's name * rename enum --------- Co-authored-by: Chris Jiang <[email protected]> --------- Co-authored-by: Jayati Tehri <[email protected]> Co-authored-by: PreetPRG <[email protected]> Co-authored-by: InbalZim <[email protected]> Co-authored-by: VIPRAY JAIN <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: Mike Harder <[email protected]> Co-authored-by: Teo Magnino Chaban <[email protected]> Co-authored-by: Konrad Jamrozik <[email protected]> Co-authored-by: Chris Jiang <[email protected]> Co-authored-by: Chris Jiang <[email protected]> Co-authored-by: williamzhao87 <[email protected]> Co-authored-by: Rajarshi Sarkar 🦄 <[email protected]> Co-authored-by: Rajarshi Sarkar <[email protected]> Co-authored-by: Liangying.Wei <[email protected]> Co-authored-by: Shawn Fang <[email protected]> Co-authored-by: mqwang <[email protected]> Co-authored-by: abhargavams <[email protected]> Co-authored-by: kanupriyasinghh <[email protected]> Co-authored-by: JainRah <[email protected]> Co-authored-by: Brandon Miller <[email protected]> Co-authored-by: Travis Wilson <[email protected]> Co-authored-by: Laurent Mazuel <[email protected]> Co-authored-by: Albert Cheng <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Jose Alvarez <[email protected]> Co-authored-by: Maxim Rytych <[email protected]> Co-authored-by: Daniel Hu <[email protected]> Co-authored-by: Kalpesh Chavan <[email protected]> Co-authored-by: Kalpesh Chavan <[email protected]> Co-authored-by: kashyap-kunal <[email protected]> Co-authored-by: ishanjindalms <[email protected]> Co-authored-by: athulvijayanmsft <[email protected]> Co-authored-by: Thomas Ricci <[email protected]> Co-authored-by: williamzhao87 <[email protected]> * Adding new query param on list job api (Azure#25375) Co-authored-by: Shail Paragbhai Shah <[email protected]> * Remove list materialization jobs api (Azure#25372) * Update mfe.json * prettify swagger * Remove example * Update readme.md * Update readme.md * Add backfill api contract changes * Fixing json * Add property bag * Modifying example --------- Co-authored-by: Shail Paragbhai Shah <[email protected]> * sweep over pipeline component (Azure#25616) * Add SSO and RootAccess (Azure#25754) Co-authored-by: Teo Magnino Chaban <[email protected]> * add EnvironmentVariables in sparkjob (Azure#25814) * Add model monitor 2023-08-01-preview changes (Azure#25785) * Add model monitor 2023-08-01-preview changes * update * run prettier * update comments * add * Add WS Vnet properties for Serverless GA (Azure#25780) * add serverless ws vnet properties * add to workspace update properties * update format * update description --------- Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Resource to ProxyResource for preview version (Azure#25906) Co-authored-by: Shail Paragbhai Shah <[email protected]> * August-2023-preview fix circular reference (Azure#25870) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule --------- Co-authored-by: Kayla Ames <[email protected]> * Update ServerlessEndpoints design (Azure#25593) * first draft redesign of ServerlessEndpoints * add getStatus.json * update examples * add LRO location header to example * add CapacityReservationGroups API * spellcheck fix * example fix * capacity reservation groups should be under resource groups * fix examples * inferenceUri -> uri * CapacityReservation -> ServerlessEndpointCapacityReservation * update description * remove ExcessCapacityReservation concept * remove parentGroupId concept * rename /status api to /getStatus * label metrics as readOnly * lintdiff GET fix * more fixes * add listBySubscription * add/fix examples * add suppression for lint error (Azure#25941) * minor fixes (Azure#25940) * Update 2023-08-01-preview swagger for workspaceRP (Azure#25532) * Update swagger * Bug fix * update * Update testconnection and example * Fix format * update custom words and example * Update missing custom words * reflect comment remove LRO opetions * make metadata a string dictionary * reflect comment * Revert "reflect comment" This reverts commit 9b85252250fd442dd891b27509f5d2e315d8aa2a. * Update with managedNetwork change included * Update managed network schema * revert metadata change * remove the RBAC properties related with shared connection * Update readme * Update suppression reason * Updated preview API to add Kernel Config (Azure#25361) * Updated preview API to add Kernel Config and LRO Headers * Fixing formatting issue * Updated as per comments * Updated as per comments * Reverting changes * Reverted header changes * Reverting change * Reverting example * Added version parameter and removed addition properties as per guidelines --------- Co-authored-by: Srivatsa Sinha <[email protected]> * Thtodoro/serverless endpoints 2023 08 01 preview fix (Azure#25993) * Capacity Reservation Groups is not an async resource, and thus does not have 202 as a response type * PATCH response must have same resource as GET/PUT APIs * add missing description * Adding Inference Pools, Groups and Endpoints recreated for Azure/azure-rest-api-specs#25783 for rebased issue (Azure#25819) * Adding Inference Pools, Groups and Endpoints * PR comments * remove EventLog and change data * remove EventLog and change data * moving endpoint as sibling to group * Moving back to the tracked resources * force change * fix the missing field --------- Co-authored-by: Raushan Kumar <[email protected]> * Make suppression more specific (Azure#26031) Co-authored-by: Teo Magnino Chaban <[email protected]> * add serverless compute settings (Azure#26007) Co-authored-by: Aaheli Chattopadhyay <[email protected]> --------- Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: Anubha Jain <[email protected]> Co-authored-by: Anubha98 <[email protected]> Co-authored-by: teochaban <[email protected]> Co-authored-by: Jayati Tehri <[email protected]> Co-authored-by: PreetPRG <[email protected]> Co-authored-by: InbalZim <[email protected]> Co-authored-by: VIPRAY JAIN <[email protected]> Co-authored-by: Dapeng Zhang <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: Mike Harder <[email protected]> Co-authored-by: Teo Magnino Chaban <[email protected]> Co-authored-by: Konrad Jamrozik <[email protected]> Co-authored-by: Chris Jiang <[email protected]> Co-authored-by: Chris Jiang <[email protected]> Co-authored-by: williamzhao87 <[email protected]> Co-authored-by: Rajarshi Sarkar 🦄 <[email protected]> Co-authored-by: Rajarshi Sarkar <[email protected]> Co-authored-by: Liangying.Wei <[email protected]> Co-authored-by: Shawn Fang <[email protected]> Co-authored-by: mqwang <[email protected]> Co-authored-by: abhargavams <[email protected]> Co-authored-by: kanupriyasinghh <[email protected]> Co-authored-by: JainRah <[email protected]> Co-authored-by: Brandon Miller <[email protected]> Co-authored-by: Travis Wilson <[email protected]> Co-authored-by: Laurent Mazuel <[email protected]> Co-authored-by: Albert Cheng <[email protected]> Co-authored-by: Weidong Xu <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Jose Alvarez <[email protected]> Co-authored-by: Maxim Rytych <[email protected]> Co-authored-by: Daniel Hu <[email protected]> Co-authored-by: Kalpesh Chavan <[email protected]> Co-authored-by: Kalpesh Chavan <[email protected]> Co-authored-by: kashyap-kunal <[email protected]> Co-authored-by: ishanjindalms <[email protected]> Co-authored-by: athulvijayanmsft <[email protected]> Co-authored-by: Thomas Ricci <[email protected]> Co-authored-by: williamzhao87 <[email protected]> Co-authored-by: shail2208 <[email protected]> Co-authored-by: Shail Paragbhai Shah <[email protected]> Co-authored-by: ghsutirtha <[email protected]> Co-authored-by: ycheng35xo <[email protected]> Co-authored-by: Mathieu St-Louis <[email protected]> Co-authored-by: ac923 <[email protected]> Co-authored-by: Aaheli Chattopadhyay <[email protected]> Co-authored-by: Teddy Todorov <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: srivatsasinha <[email protected]> Co-authored-by: Srivatsa Sinha <[email protected]> Co-authored-by: Raushan Kumar <[email protected]> Co-authored-by: Raushan Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24842