Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] add DPG models #24849

Closed
iscai-msft opened this issue Jun 14, 2022 · 2 comments
Closed

[core] add DPG models #24849

iscai-msft opened this issue Jun 14, 2022 · 2 comments
Assignees

Comments

@iscai-msft
Copy link
Contributor

We want to add DPG models to azure.core.serialization.

These models should behave like a mapping, and as a more traditional model. We want these models to be able to replace raw MutableMapping JSON responses that we currently return in DPG generation. This means, when accessed with dict syntax, they should behave exactly the same as a MutableMapping. When accessed with attribute syntax, we will add deserialization logic onto the returned responses. For example, if you access a datetime property with dict syntax, (model["datetime"]), you will get back the datetime string, but when accessed with attribute syntax (model.datetime), you will get back the deserialized datetime object.

We want these models to be easy to read and write, and we want the information needed to create these models to be public knowledge. We used to generate our msrest models with a bunch of hidden dictionaries that were vital to the serialization and deserialization logic. For these new models, we want them to be as above board as possible.

Additionally, one of the main added values of models is to have additional documentation and typehint landing pages. Our models must prioritize excellent documentation and intellisense. When accessing our models with attribute syntax, and creating them with attribute syntax, they should be fully documented with type hinting.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 14, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Cosmos:0.21733461,Azure.Core:0.055009324,Cognitive - Form Recognizer:0.054307804'

@iscai-msft iscai-msft added DPG/RLC v1.1 and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jun 14, 2022
@iscai-msft iscai-msft self-assigned this Jun 14, 2022
Copy link

Hi @iscai-msft, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants