Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos] Update cosmos codeowners #23729

Merged
merged 79 commits into from
Apr 13, 2022
Merged

[Cosmos] Update cosmos codeowners #23729

merged 79 commits into from
Apr 13, 2022

Conversation

simorenoh
Copy link
Member

@simorenoh simorenoh commented Mar 29, 2022

Adding @annatisch and @tjprescott as code owners to cosmos since they have been checking most of the big PR's already, and @JericHunter who is new to the SDK.

simorenoh and others added 30 commits August 13, 2021 13:14
* Removed some stuff

* Looking at constructors

* Updated request

* Added client close

* working client creation

Co-authored-by: simorenoh <[email protected]>
database read works, but ignored exception is returned:
Fatal error on SSL transport
NoneType has no attribute 'send' (_loop._proactor.send)
RuntimeError: Event loop is closed
Unclosed connector/ connection
Added methods needed to use async with when initializing client, but logs output "Exception ignored... Runtime Error: Event loop is closed"
missing upsert and other resources
missing read_all_items and both query methods for container class
Complete item CRUD functionality - only missing queries
Query functionality and container query methods
also fixed README and added examples_async
@jsquire jsquire requested a review from annatisch March 29, 2022 18:06
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@tjprescott tjprescott enabled auto-merge (squash) April 1, 2022 22:23
@simorenoh
Copy link
Member Author

/azp run python - cosmos - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@simorenoh simorenoh requested a review from JericHunter April 6, 2022 20:14
@simorenoh
Copy link
Member Author

/check-enforcer evaluate

@tjprescott
Copy link
Member

/check-enforcer override

@tjprescott tjprescott merged commit 23f486b into Azure:main Apr 13, 2022
@simorenoh simorenoh deleted the update-cosmos-codeowners branch April 14, 2022 14:29
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request May 26, 2023
Release app microsoft.app 2023 04 01 preview (Azure#24103)

* Adds base for updating Microsoft.App from version preview/2022-11-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* support terminationGracePeriodSeconds (Azure#23476)

* Support SubPath in volume mount and mount options for azure file volume (Azure#23496)

* Support SubPath in volume mount and mount options for azure file volume

* update description

* Add replica/container running state (Azure#23617)

* add replica/container running state

* spell error fix

* add event trigger for Container Jobs 2023-04-01-preview (Azure#23724)

* add event trigger for Container Jobs 2023-04-01-preview

* prettier and avocado fix

---------

Co-authored-by: Taher Darolywala <[email protected]>

* Resolve Comments for Event driven jobs (Azure#23729)

* Resolve Comments for Event driven jobs

* change scaling rule to azure-servicebus

* update example

---------

Co-authored-by: Taher Darolywala <[email protected]>

* Swagger change for mtls and runningState (Azure#23767)

* 1. Add mtls properties for managed ManagedEnvironment
2. Add running state for Revision

* fix

* Add ContainerApp Start/Stop for 2023-04-01-preview (Azure#23497)

* Add ContainerApp Start/Stop for 2023-04-01-preview

* Fix validation error

* Fix validation error

* Change example to add location in header

* Fix lint error

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Add new source controls properties (Azure#23891)

* Add new source controls properties

* Update examples

* fix examples

* Change event trigger replica properties to executions, add polling in… (Azure#23810)

* Change event trigger replica properties to executions, add polling interval to event trigger, fix typos and descriptions to accommodate both apps and jobs

* Fix validation errors

* code review comments

* Fix formatting errors

* Code review comments

* Add single execution history endpoint, refactor copy paste code for j… (Azure#23816)

* Add single execution history endpoint, refactor copy paste code for jobName and jobExecutionName path parameters

* Fix validation errors from ARM

* Fix validation errors

* Code review comments

* Fix validation error

* code review comments from Anand

* Add springboard properties (Azure#23932)

* Add springboard properties

* CR comments

* Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json

Co-authored-by: Jitin John <[email protected]>

* Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json

Co-authored-by: Jitin John <[email protected]>

---------

Co-authored-by: Jitin John <[email protected]>

* Fix Lint issues in ContainerApps.json (Azure#24107)

* Fix lint issue

* Fix format issue

* Fix json format issue

* Fix model validation

* Fix lint error

* fix param (Azure#24166)

Co-authored-by: Chenghui Yu <[email protected]>

---------

Co-authored-by: Zunli Hu <[email protected]>
Co-authored-by: njucz <[email protected]>
Co-authored-by: LaylaLiu-gmail <[email protected]>
Co-authored-by: Xingjian Wang <[email protected]>
Co-authored-by: Taher Daroly <[email protected]>
Co-authored-by: Taher Darolywala <[email protected]>
Co-authored-by: zhenqxuMSFT <[email protected]>
Co-authored-by: Zijian-Ju <[email protected]>
Co-authored-by: Sanchit Mehta <[email protected]>
Co-authored-by: trajkobal <[email protected]>
Co-authored-by: Ahmed ElSayed <[email protected]>
Co-authored-by: Jitin John <[email protected]>
Co-authored-by: Seris370 <[email protected]>
Co-authored-by: Chenghui Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants