Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricsadvisor] clients should accept api_version kwarg #24107

Closed
kristapratico opened this issue Apr 20, 2022 · 1 comment
Closed

[metricsadvisor] clients should accept api_version kwarg #24107

kristapratico opened this issue Apr 20, 2022 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor

Comments

@kristapratico
Copy link
Member

kristapratico commented Apr 20, 2022 •
edited
Loading

We are doing a pylint ignore right now so we don't break core ci, but this should be added in the next release.

#24105
@kristapratico kristapratico added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Apr 20, 2022
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue May 26, 2023
@Juliehzl @njuCZ
@LaylaLiu-gmail @xwang971 @tdaroly @zhenqxuMSFT @Zijian-Ju @sanchitmehta @trajkobal @ahmelsayed @jijohn14 @Seris370
CodeGen from PR 24103 in Azure/azure-rest-api-specs
846312f 
Release app microsoft.app 2023 04 01 preview (Azure#24103)

* Adds base for updating Microsoft.App from version preview/2022-11-01-preview to version 2023-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* support terminationGracePeriodSeconds (Azure#23476)

* Support SubPath in volume mount and mount options for azure file volume (Azure#23496)

* Support SubPath in volume mount and mount options for azure file volume

* update description

* Add replica/container running state (Azure#23617)

* add replica/container running state

* spell error fix

* add event trigger for Container Jobs 2023-04-01-preview (Azure#23724)

* add event trigger for Container Jobs 2023-04-01-preview

* prettier and avocado fix

---------

Co-authored-by: Taher Darolywala <[email protected]>

* Resolve Comments for Event driven jobs (Azure#23729)

* Resolve Comments for Event driven jobs

* change scaling rule to azure-servicebus

* update example

---------

Co-authored-by: Taher Darolywala <[email protected]>

* Swagger change for mtls and runningState (Azure#23767)

* 1. Add mtls properties for managed ManagedEnvironment
2. Add running state for Revision

* fix

* Add ContainerApp Start/Stop for 2023-04-01-preview (Azure#23497)

* Add ContainerApp Start/Stop for 2023-04-01-preview

* Fix validation error

* Fix validation error

* Change example to add location in header

* Fix lint error

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Fix lint issue

* Add new source controls properties (Azure#23891)

* Add new source controls properties

* Update examples

* fix examples

* Change event trigger replica properties to executions, add polling in… (Azure#23810)

* Change event trigger replica properties to executions, add polling interval to event trigger, fix typos and descriptions to accommodate both apps and jobs

* Fix validation errors

* code review comments

* Fix formatting errors

* Code review comments

* Add single execution history endpoint, refactor copy paste code for j… (Azure#23816)

* Add single execution history endpoint, refactor copy paste code for jobName and jobExecutionName path parameters

* Fix validation errors from ARM

* Fix validation errors

* Code review comments

* Fix validation error

* code review comments from Anand

* Add springboard properties (Azure#23932)

* Add springboard properties

* CR comments

* Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json

Co-authored-by: Jitin John <[email protected]>

* Update specification/app/resource-manager/Microsoft.App/preview/2023-04-01-preview/examples/ContainerApps_CreateOrUpdate.json

Co-authored-by: Jitin John <[email protected]>

---------

Co-authored-by: Jitin John <[email protected]>

* Fix Lint issues in ContainerApps.json (Azure#24107)

* Fix lint issue

* Fix format issue

* Fix json format issue

* Fix model validation

* Fix lint error

* fix param (Azure#24166)

Co-authored-by: Chenghui Yu <[email protected]>

---------

Co-authored-by: Zunli Hu <[email protected]>
Co-authored-by: njucz <[email protected]>
Co-authored-by: LaylaLiu-gmail <[email protected]>
Co-authored-by: Xingjian Wang <[email protected]>
Co-authored-by: Taher Daroly <[email protected]>
Co-authored-by: Taher Darolywala <[email protected]>
Co-authored-by: zhenqxuMSFT <[email protected]>
Co-authored-by: Zijian-Ju <[email protected]>
Co-authored-by: Sanchit Mehta <[email protected]>
Co-authored-by: trajkobal <[email protected]>
Co-authored-by: Ahmed ElSayed <[email protected]>
Co-authored-by: Jitin John <[email protected]>
Co-authored-by: Seris370 <[email protected]>
Co-authored-by: Chenghui Yu <[email protected]>
@kristapratico
Copy link
Member Author

Closing, unlikely to have another release (service retires in Oct 2026).

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kristapratico