Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify LogsQueryClient query parameter description #20467

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

scottaddie
Copy link
Member

@scottaddie scottaddie commented Aug 30, 2021

Addresses #20461

Summary of changes

  • Make it clear that the LogsQueryClient "query" methods except Kusto queries. This came up as a source of confusion in the Beta 4 UX study when participants switched from using the MetricsQueryClient, where Kusto isn't used.
  • Update Log Analytics link to the Kusto docs.microsoft.com link that it redirects to.
  • Fix typo. "workspsce" --> "workspace"

@scottaddie scottaddie requested a review from rakshith91 as a code owner August 30, 2021 22:40
@rakshith91 rakshith91 merged commit a2a5bbc into main Aug 31, 2021
@rakshith91 rakshith91 deleted the scottaddie/monitor-logs-kusto branch August 31, 2021 01:45
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 31, 2021
…into switch_to_protocol

* 'main' of https://github.com/Azure/azure-sdk-for-python:
  release_iseus_status_auto_reply (Azure#20441)
  Clarify LogsQueryClient query parameter description (Azure#20467)
  Sync eng/common directory with azure-sdk-tools for PR 1953 (Azure#20466)
  Skip eng common workflow enforcer for private repos (Azure#20462)
  remove iter_text and iter_lines (Azure#20460)
iscai-msft added a commit that referenced this pull request Aug 31, 2021
…into header_tuples

* 'main' of https://github.com/Azure/azure-sdk-for-python: (21 commits)
  [Key Vault] Add 7.3-preview support for certificates (#20477)
  Use dummy values and correct code rendering in README (#20322)
  Use CredScan-suppressed dummy password in sample (#20468)
  Fix type annotation in azure.storage.blob (#20084)
  Adding static checks (#20457)
  release_iseus_status_auto_reply (#20441)
  Clarify LogsQueryClient query parameter description (#20467)
  Sync eng/common directory with azure-sdk-tools for PR 1953 (#20466)
  Skip eng common workflow enforcer for private repos (#20462)
  remove iter_text and iter_lines (#20460)
  [ServiceBus] Improve test stability and cpu usage (#20352)
  t2-Netapp-update-to-2021-06-01 (#20453)
  [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423)
  Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450)
  New dummy password in README (#20328)
  ensure test principal creation succeeds properly (#20446)
  Update question-answering readme links (#20439)
  Stip empty changelog sections before release (#20437)
  [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422)
  [AutoRelease] t2-iothub-2021-08-25-25696 (#20409)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 31, 2021
…into update_lro_paging

* 'main' of https://github.com/Azure/azure-sdk-for-python:
  [Core] Follow RFC 3339 datetime formatting for AzureJSONEncoder (Azure#20346)
  [Key Vault] Add 7.3-preview support for certificates (Azure#20477)
  Use dummy values and correct code rendering in README (Azure#20322)
  Use CredScan-suppressed dummy password in sample (Azure#20468)
  Fix type annotation in azure.storage.blob (Azure#20084)
  Adding static checks (Azure#20457)
  release_iseus_status_auto_reply (Azure#20441)
  Clarify LogsQueryClient query parameter description (Azure#20467)
  Sync eng/common directory with azure-sdk-tools for PR 1953 (Azure#20466)
  Skip eng common workflow enforcer for private repos (Azure#20462)
  remove iter_text and iter_lines (Azure#20460)
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Oct 20, 2022
[Hub Generated] Publish private branch 'eventListener' (Azure#20467)

* Adds base for updating Microsoft.SignalRService from version stable/2021-10-01 to version 2022-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* "ot" -> "or"

* Update swagger

* max listener count = 10
* Add custom cert and custom domain

* Add examples

* Add fina-state-via for delete

* Fix markdown format

* Rename discriminator and enum type

* Add x-ms-identifier

* Update markdown settings

* Fix 204 description

* Add 200 to custom domain PUT

* Revert adding 200 response code to put

* try fix readiness test

1. change default tire to premium
2. remove private endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants