Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotation in azure.storage.blob #20084

Merged
merged 2 commits into from
Aug 31, 2021
Merged

Conversation

rnestler
Copy link
Contributor

@rnestler rnestler commented Aug 4, 2021

This fixes the type annotations in azure.storage.blob which mypy found. See also #20083

@ghost ghost added Storage Storage Service (Queues, Blobs, Files) customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 4, 2021
@ghost
Copy link

ghost commented Aug 4, 2021

Thank you for your contribution rnestler! We will review the pull request and get back to you soon.

@rnestler rnestler changed the title Fix type annotation for get_api_version Fix type annotation in azure.storage.blob Aug 4, 2021
@rnestler rnestler mentioned this pull request Aug 16, 2021
@xiafu-msft xiafu-msft enabled auto-merge (squash) August 31, 2021 17:33
@xiafu-msft xiafu-msft closed this Aug 31, 2021
auto-merge was automatically disabled August 31, 2021 17:33

Pull request was closed

@xiafu-msft xiafu-msft reopened this Aug 31, 2021
@xiafu-msft xiafu-msft merged commit d3d7e3e into Azure:main Aug 31, 2021
@rnestler rnestler deleted the patch-1 branch August 31, 2021 17:58
iscai-msft added a commit that referenced this pull request Aug 31, 2021
…into header_tuples

* 'main' of https://github.com/Azure/azure-sdk-for-python: (21 commits)
  [Key Vault] Add 7.3-preview support for certificates (#20477)
  Use dummy values and correct code rendering in README (#20322)
  Use CredScan-suppressed dummy password in sample (#20468)
  Fix type annotation in azure.storage.blob (#20084)
  Adding static checks (#20457)
  release_iseus_status_auto_reply (#20441)
  Clarify LogsQueryClient query parameter description (#20467)
  Sync eng/common directory with azure-sdk-tools for PR 1953 (#20466)
  Skip eng common workflow enforcer for private repos (#20462)
  remove iter_text and iter_lines (#20460)
  [ServiceBus] Improve test stability and cpu usage (#20352)
  t2-Netapp-update-to-2021-06-01 (#20453)
  [AutoRelease] t2-keyvault-2021-08-26-55443 (#20423)
  Sync eng/common directory with azure-sdk-tools for PR 1943 (#20450)
  New dummy password in README (#20328)
  ensure test principal creation succeeds properly (#20446)
  Update question-answering readme links (#20439)
  Stip empty changelog sections before release (#20437)
  [AutoRelease] t2-healthcareapis-2021-08-26-27542 (#20422)
  [AutoRelease] t2-iothub-2021-08-25-25696 (#20409)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 31, 2021
…into update_lro_paging

* 'main' of https://github.com/Azure/azure-sdk-for-python:
  [Core] Follow RFC 3339 datetime formatting for AzureJSONEncoder (Azure#20346)
  [Key Vault] Add 7.3-preview support for certificates (Azure#20477)
  Use dummy values and correct code rendering in README (Azure#20322)
  Use CredScan-suppressed dummy password in sample (Azure#20468)
  Fix type annotation in azure.storage.blob (Azure#20084)
  Adding static checks (Azure#20457)
  release_iseus_status_auto_reply (Azure#20441)
  Clarify LogsQueryClient query parameter description (Azure#20467)
  Sync eng/common directory with azure-sdk-tools for PR 1953 (Azure#20466)
  Skip eng common workflow enforcer for private repos (Azure#20462)
  remove iter_text and iter_lines (Azure#20460)
iscai-msft pushed a commit that referenced this pull request Sep 29, 2021
* Fix type annotation for get_api_version

* Fix type annotation in _get_match_headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants