Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud event should parse smaller ms precisions #19259

Merged
merged 6 commits into from
Jun 22, 2021
Merged

Cloud event should parse smaller ms precisions #19259

merged 6 commits into from
Jun 22, 2021

Conversation

rakshith91
Copy link
Contributor

@rakshith91 rakshith91 commented Jun 15, 2021 •
edited
Loading

Fixes #19248

UPDATE:

Added more tests - this is an expected behavior

@ghost ghost added the Azure.Core label Jun 15, 2021
@rakshith91 rakshith91 closed this Jun 15, 2021
@rakshith91 rakshith91 reopened this Jun 15, 2021
@rakshith91 rakshith91 changed the title Cloud event should parse smalled ms precisions Cloud event should parse smaller ms precisions Jun 15, 2021
lmazuel
lmazuel reviewed Jun 16, 2021
View reviewed changes
Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused a bit, I need to re-read RFC3339 or ISO8601

sdk/core/azure-core/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/core/azure-core/tests/test_messaging_cloud_event.py Outdated Show resolved Hide resolved
swathipil
swathipil reviewed Jun 22, 2021
View reviewed changes
sdk/core/azure-core/tests/test_messaging_cloud_event.py Outdated
Comment on lines 413 to 431
def test_cloud_custom_dict_ms_precision_is_gt_six_z_not():
time ="2021-02-18T20:18:10.539861122+00:00"
date_obj = _convert_to_isoformat(time)

assert date_obj.month == 2
assert date_obj.day == 18
assert date_obj.hour == 20
assert date_obj.microsecond == 539861

def test_cloud_custom_dict_ms_precision_is_lt_six_z_not():
time ="2021-02-18T20:18:10.123+00:00"
date_obj = _convert_to_isoformat(time)

assert date_obj.month == 2
assert date_obj.day == 18
assert date_obj.hour == 20
assert date_obj.microsecond == 123000

def test_cloud_custom_dict_ms_precision_is_eq_six_z_not():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like times in these don't end with the Z?

swathipil
swathipil approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakshith91 rakshith91 enabled auto-merge (squash) June 22, 2021 22:40
@rakshith91 rakshith91 merged commit 2f0afe1 into Azure:main Jun 22, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 24, 2021
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
4cbf6a8 
…into get_testserver_working

* 'main' of https://github.com/Azure/azure-sdk-for-python: (45 commits)
  ignore coretestserver readme (Azure#19436)
  Add Ubuntu 20 to local dns bypass template (Azure#19432)
  Sync eng/common directory with azure-sdk-tools for PR 1729 (Azure#19415)
  Async/BearerTokenCredentialPolicy consistently calls on_exception (Azure#19195)
  [EventHubs] Fix bug in sending stress test code and update default stress test settings (Azure#19429)
  [EventHubs] Get IoT Hub Name from Redirect Address in sample (Azure#19314)
  [textanalytics] regen on v3.1 (Azure#19193)
  Adapt EG to arm template (Azure#19262)
  [Key Vault] Extend pipeline test timeout (Azure#19404)
  Update platform matrix to ubuntu 20 (Azure#19296)
  [AppConfig] Add lock to SyncTokenPolicy (Azure#19395)
  Regenerate monitor code (Azure#19375)
  Increment version for keyvault releases (Azure#19402)
  Aggregation should be a list (Azure#19381)
  [azure-mgmt-monitor] skip test to unblock ci (Azure#19390)
  Cloud event should parse smaller ms precisions (Azure#19259)
  Update release date (Azure#19399)
  [Communication]: use x-ms-date for hmac (Azure#19396)
  [Key Vault] Performance tests for certificates, keys, and secrets (Azure#19002)
  Deprecate azure-monitor (Azure#19384)
  ...
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Jun 24, 2022
@joslinmicrosoft @tanaybhartia
@tabhar-msft @JarodAertsMs @annikel @cschen13 @JarodAertsMsft @edwin-msft @weidongxu-microsoft @jiansong-msft @dejo-msft @alexkarcher-msft
CodeGen from PR 19430 in Azure/azure-rest-api-specs
c6a7ea2 
Web ant97 2022 03 01 (Azure#19430)

* Adds base for updating Microsoft.Web from version stable/2021-03-01 to version 2022-03-01

* Updates readme

* Updates API version in new specs and examples

* Carry fwd Microsoft.CertificateRegistration and Microsoft.DomainRegis… (Azure#18460)

* Carry fwd Microsoft.CertificateRegistration and Microsoft.DomainRegistration RPs to Api-version 2022-03-01

* Add x-ms-enum for array of inline enums. Fix reference to older api version for common defs

* Add examples for App Service Certificate orders

* Add suppressions back

* Add examples for Microsoft.DomainRegistration RP

* Fixes from prettier

* Remove unused example

* Add Unhealthy CustomDomainStatus for StaticSites (Azure#18557)

* Adding VnetRouteAllEnabled, VnetImagePullEnabled, VnetContentShareEnabled site properties to CommonDefinitions (Azure#18627)

* Added vnet realted site properties to common definitions

* removed tab

Co-authored-by: Tanay Bhartia <[email protected]>

* Add Ftp/Remote debug properties to Ase network config (Azure#18549)

* Add Ftp/Remote debug properties to Ase network config

* Switched changes to the right file

* Add Networking config to hosting environment creates

* Added some of the missing examples

* Remove disallowed properties from example Ase GET response

* Adjusted responses from other gets

* Added a bunch more examples

* Added other missing examples for Ase.

* Added more missing examples for Ase.

* fixed formatting

* Edit some examples, add back privatelink apis and try to supress the errors for missing examples.

* Fix suppress spelling and fix prettier

* Added missing privatelink examples since suppressing did not work

* Add Bring your own Backend operations (Azure#18517)

* add bring your own backend operations

* add missing files

* fix json formattin

* validation fixes

* fix

* fix more validation

* fix ids

* fix model validation

* fix descriptions

* fix environmentName description

* change to 202

* revert change to 202

* customhostnamesites optional param for 2022 API version (Azure#18670)

* fix DUPLICATE_PARAMETER

* prettier

* fix  OBJECT_ADDITIONAL_PROPERTIES

* fix random sub in examples

* add optional hostname param to customHostnameSites RT and add examples

* move changes from 2021 api version to 2022

* move examples to 2022

* Revert "add optional hostname param to customHostnameSites RT and add examples"

This reverts commit 7fc318e190de2108222dbb869d9a6219a02cae2f.

* remove examples from 2021

* fix lintDiff

* prettier fix

* model validation fix

* suppress model validation in readme

Co-authored-by: Elle Tojaroon <[email protected]>

* [Microsoft.Web] Add CustomDnsSuffixConfiguration to ASE (Azure#18553)

* [Microsoft.Web] Add CustomDnsSuffixConfiguration to AppServiceEnvironments

* Add examples

* Fix style issues

* Add customdnssuffix to custom-words

* Add CustomDnsSuffixConfiguration to AppServiceEnvironment definition

* Address remaining model validation errors

* Adjusted networking configuration definitions

* Addressed Arm review feedback

Co-authored-by: Jarod Aerts <[email protected]>

* Fork/web ant97 2022 03 01 (Azure#19259)

* Added DeploymentStatus API specs and examples

* change status to enum, rm extra dot

* suppress missing examples for now

* rm id from List Deployment Slot examples

* rm location, and rename deploymentId in GetSiteDeploymentStatus examples

* change model as string to true, add 202 operations for DeploymentStatus ops to spec

* rename operationId to deploymentStatusId, undo deploymentId rename

* add long running op, as per linter

Co-authored-by: Shubham Dhond <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>

* PublicNetworkAccess Swagger Change (Azure#19352)

* add publicNetworkAccess property in site for swagger

* add suppression to fix Model Validation CI

* Add allowed values in the description

* Add specs for Hosting Environment Maintenance Control (Azure#18691)

* Add documentation for Hosting Environment Maintenance Control

* Update example file name

* Make UpgradePreference non-nullable

* Correct indentation to 2 spaces

* Fix upgradePreference indentation

* Address swagger feedback. Add enums with descriptions.

* Move testNotification to request body. Update description text

* Fix testNotification

* Fix example

* Replace TestNotification parameter with TestUpgradeNotification API

* Rename to TestUpgradeAvailableNotification

* Added logic apps operations (Azure#18604)

* Added Initial Operations and some definitions

* Adding additional objects to support Logic Apps operations

* Updated path and parameters to match testing

* Prettier Fixes

* oav validat-example fixes

* Github validation fixes

* Prettier

* Updated examples and paths

* Prettier

* Revert "Prettier"

This reverts commit da090adf8005e0bd6fdc2ddebbd4390e5c4b6b20.

* Prettier

* Fixed model validation errors

* Filled in nextLinkName values

* Fixing swagger lintdiff errors

* added x-ms-long-running to async calls

* Adds numberOfWorkers to app service plan (Azure#19475)

* Adds numberOfWorkers to app service plan

* Add suppression for missing ASP examples

* Updating to fix workflow errors (Azure#19490)

* Removed conflicting resource definition and added reference to CommonDefinitions.json (Azure#19507)

* Removed conflicting resource definition and added reference to CommonDefinitions.json

* Updated resource to have workflow version

* Updated nextLink object to be correctly tagged (Azure#19560)

* Updated nextLink object to be correctly tagged

* Adding value placeholder

* Updated SKU to remove conflict

* Updated x-ms-enum

* Added missing model

* Adding more missing models

* Add suppressions for missing examples (Azure#19563)

Co-authored-by: Joseph Lin <[email protected]>
Co-authored-by: Tanay Bhartia <[email protected]>
Co-authored-by: Tanay Bhartia <[email protected]>
Co-authored-by: JarodAertsMs <[email protected]>
Co-authored-by: annikel <[email protected]>
Co-authored-by: Paviya (Elle) Tojaroon <[email protected]>
Co-authored-by: Elle Tojaroon <[email protected]>
Co-authored-by: Chris Chen <[email protected]>
Co-authored-by: Jarod Aerts <[email protected]>
Co-authored-by: edwin-msft <[email protected]>
Co-authored-by: Shubham Dhond <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: jiansong-msft <[email protected]>
Co-authored-by: Derek Johnson <[email protected]>
Co-authored-by: Alex Karcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel left review comments

@swathipil swathipil swathipil approved these changes

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner

Assignees
No one assigned
Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CloudEvent fails to parse datetime if microsoeconds precision is lesser than 6 decimals
3 participants
@rakshith91 @lmazuel @swathipil