-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EventHubs] Get IoT Hub Name from Redirect Address in sample #19314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The approach looks correct to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks amazing :)
could you add a short comment to help understand the expression?
also I believe it is tested? (e.g. names longer than 25 chars)
Hello @swathipil! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…into get_testserver_working * 'main' of https://github.com/Azure/azure-sdk-for-python: (45 commits) ignore coretestserver readme (Azure#19436) Add Ubuntu 20 to local dns bypass template (Azure#19432) Sync eng/common directory with azure-sdk-tools for PR 1729 (Azure#19415) Async/BearerTokenCredentialPolicy consistently calls on_exception (Azure#19195) [EventHubs] Fix bug in sending stress test code and update default stress test settings (Azure#19429) [EventHubs] Get IoT Hub Name from Redirect Address in sample (Azure#19314) [textanalytics] regen on v3.1 (Azure#19193) Adapt EG to arm template (Azure#19262) [Key Vault] Extend pipeline test timeout (Azure#19404) Update platform matrix to ubuntu 20 (Azure#19296) [AppConfig] Add lock to SyncTokenPolicy (Azure#19395) Regenerate monitor code (Azure#19375) Increment version for keyvault releases (Azure#19402) Aggregation should be a list (Azure#19381) [azure-mgmt-monitor] skip test to unblock ci (Azure#19390) Cloud event should parse smaller ms precisions (Azure#19259) Update release date (Azure#19399) [Communication]: use x-ms-date for hmac (Azure#19396) [Key Vault] Performance tests for certificates, keys, and secrets (Azure#19002) Deprecate azure-monitor (Azure#19384) ...
…9314) Fixes: Azure#19087 Follows[ C# sample,](https://github.com/Azure/azure-sdk-for-net/blob/350c23ea19ed76d74f7d97dfe3aec82671fdcc9d/samples/iothub-connect-to-eventhubs/IotHubConnection.cs#L97) which also gets IoT Hub name from redirect address.
Fixes: #19087
Follows C# sample, which also gets IoT Hub name from redirect address.