Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tables] Test fixes #18075

Merged
14 commits merged into from
Apr 19, 2021
Merged

[Tables] Test fixes #18075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ee74d43
fixing test failure b/c of cosmos rate limiting
seankane-msft Apr 8, 2021
83b0c0b
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
seankane-msft Apr 8, 2021
e3a4779
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
seankane-msft Apr 15, 2021
b801f4b
removed a couple, fixed a few
seankane-msft Apr 15, 2021
d035b6f
two more fixes
seankane-msft Apr 15, 2021
f92ff0c
fixed locale test
seankane-msft Apr 15, 2021
f27a892
fixes to test_timezone
seankane-msft Apr 15, 2021
5bf5ddd
fixed issue with select in test
seankane-msft Apr 15, 2021
62d9143
fixed service properties for cosmos
seankane-msft Apr 15, 2021
5fedcb4
service_stats do not work for cosmos
seankane-msft Apr 15, 2021
fa7f590
service_stats do not work for cosmos
seankane-msft Apr 15, 2021
825ca5d
made some tests python3 only
seankane-msft Apr 15, 2021
85b723b
removing locale tests because of issues with backwards compatability
seankane-msft Apr 15, 2021
84eb83e
Merge branch 'master' into tables-test-fix
seankane-msft Apr 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/tables/azure-data-tables/azure/data/tables/_table_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ def list_entities(
"""
user_select = kwargs.pop("select", None)
if user_select and not isinstance(user_select, str):
user_select = ", ".join(user_select)
user_select = ",".join(user_select)
Copy link
Member Author

@seankane-msft seankane-msft Apr 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the space because cosmos will keep the space there on the returned object, which makes the deserialized object have a parameter with a preceding space. ie. my_entity[' value'] instead of my_entity['value'].

top = kwargs.pop("results_per_page", None)

command = functools.partial(self._client.table.query_entities, **kwargs)
Expand Down
2 changes: 1 addition & 1 deletion sdk/tables/azure-data-tables/azure/data/tables/aio/_table_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ def list_entities(
"""
user_select = kwargs.pop("select", None)
if user_select and not isinstance(user_select, str):
user_select = ", ".join(user_select)
user_select = ",".join(user_select)
top = kwargs.pop("results_per_page", None)

command = functools.partial(self._client.table.query_entities, **kwargs)
Expand Down
24 changes: 12 additions & 12 deletions sdk/tables/azure-data-tables/tests/recordings/test_table.test_locale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,27 @@ interactions:
DataServiceVersion:
- '3.0'
Date:
- Tue, 29 Sep 2020 17:15:25 GMT
- Thu, 15 Apr 2021 16:20:36 GMT
User-Agent:
- azsdk-python-data-tables/12.0.0b2 Python/3.8.4 (Windows-10-10.0.19041-SP0)
- azsdk-python-data-tables/12.0.0b7 Python/3.9.0rc1 (Windows-10-10.0.19041-SP0)
x-ms-date:
- Tue, 29 Sep 2020 17:15:25 GMT
- Thu, 15 Apr 2021 16:20:36 GMT
x-ms-version:
- '2019-02-02'
method: POST
uri: https://tablesteststorname.table.core.windows.net/Tables
uri: https://fake_table_account.table.core.windows.net/Tables
response:
body:
string: '{"odata.metadata":"https://tablesteststorname.table.core.windows.net/$metadata#Tables/@Element","TableName":"pytablesync672108e5"}'
string: '{"odata.metadata":"https://fake_table_account.table.core.windows.net/$metadata#Tables/@Element","TableName":"pytablesync672108e5"}'
headers:
cache-control:
- no-cache
content-type:
- application/json;odata=minimalmetadata;streaming=true;charset=utf-8
date:
- Tue, 29 Sep 2020 17:15:25 GMT
- Thu, 15 Apr 2021 16:20:37 GMT
location:
- https://tablesteststorname.table.core.windows.net/Tables('pytablesync672108e5')
- https://fake_table_account.table.core.windows.net/Tables('pytablesync672108e5')
server:
- Windows-Azure-Table/1.0 Microsoft-HTTPAPI/2.0
transfer-encoding:
Expand All @@ -59,15 +59,15 @@ interactions:
Content-Length:
- '0'
Date:
- Tue, 29 Sep 2020 17:15:26 GMT
- Thu, 15 Apr 2021 16:20:37 GMT
User-Agent:
- azsdk-python-data-tables/12.0.0b2 Python/3.8.4 (Windows-10-10.0.19041-SP0)
- azsdk-python-data-tables/12.0.0b7 Python/3.9.0rc1 (Windows-10-10.0.19041-SP0)
x-ms-date:
- Tue, 29 Sep 2020 17:15:26 GMT
- Thu, 15 Apr 2021 16:20:37 GMT
x-ms-version:
- '2019-02-02'
method: DELETE
uri: https://tablesteststorname.table.core.windows.net/Tables('pytablesync672108e5')
uri: https://fake_table_account.table.core.windows.net/Tables('pytablesync672108e5')
response:
body:
string: ''
Expand All @@ -77,7 +77,7 @@ interactions:
content-length:
- '0'
date:
- Tue, 29 Sep 2020 17:15:25 GMT
- Thu, 15 Apr 2021 16:20:37 GMT
server:
- Windows-Azure-Table/1.0 Microsoft-HTTPAPI/2.0
x-content-type-options:
Expand Down
28 changes: 14 additions & 14 deletions sdk/tables/azure-data-tables/tests/recordings/test_table_async.test_locale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,58 +11,58 @@ interactions:
DataServiceVersion:
- '3.0'
Date:
- Tue, 29 Sep 2020 17:05:44 GMT
- Thu, 15 Apr 2021 16:20:37 GMT
User-Agent:
- azsdk-python-data-tables/12.0.0b2 Python/3.8.4 (Windows-10-10.0.19041-SP0)
- azsdk-python-data-tables/12.0.0b7 Python/3.9.0rc1 (Windows-10-10.0.19041-SP0)
x-ms-date:
- Tue, 29 Sep 2020 17:05:44 GMT
- Thu, 15 Apr 2021 16:20:37 GMT
x-ms-version:
- '2019-02-02'
method: POST
uri: https://tablesteststorname.table.core.windows.net/Tables
uri: https://fake_table_account.table.core.windows.net/Tables
response:
body:
string: '{"odata.metadata":"https://tablesteststorname.table.core.windows.net/$metadata#Tables/@Element","TableName":"pytableasynca6820b62"}'
string: '{"odata.metadata":"https://fake_table_account.table.core.windows.net/$metadata#Tables/@Element","TableName":"pytableasynca6820b62"}'
headers:
cache-control: no-cache
content-type: application/json;odata=minimalmetadata;streaming=true;charset=utf-8
date: Tue, 29 Sep 2020 17:05:44 GMT
location: https://tablesteststorname.table.core.windows.net/Tables('pytableasynca6820b62')
date: Thu, 15 Apr 2021 16:20:37 GMT
location: https://fake_table_account.table.core.windows.net/Tables('pytableasynca6820b62')
server: Windows-Azure-Table/1.0 Microsoft-HTTPAPI/2.0
transfer-encoding: chunked
x-content-type-options: nosniff
x-ms-version: '2019-02-02'
status:
code: 201
message: Created
url: https://tablesteststorname.table.core.windows.net/Tables
url: https://seankaneprim.table.core.windows.net/Tables
- request:
body: null
headers:
Accept:
- application/json
Date:
- Tue, 29 Sep 2020 17:05:44 GMT
- Thu, 15 Apr 2021 16:20:38 GMT
User-Agent:
- azsdk-python-data-tables/12.0.0b2 Python/3.8.4 (Windows-10-10.0.19041-SP0)
- azsdk-python-data-tables/12.0.0b7 Python/3.9.0rc1 (Windows-10-10.0.19041-SP0)
x-ms-date:
- Tue, 29 Sep 2020 17:05:44 GMT
- Thu, 15 Apr 2021 16:20:38 GMT
x-ms-version:
- '2019-02-02'
method: DELETE
uri: https://tablesteststorname.table.core.windows.net/Tables('pytableasynca6820b62')
uri: https://fake_table_account.table.core.windows.net/Tables('pytableasynca6820b62')
response:
body:
string: ''
headers:
cache-control: no-cache
content-length: '0'
date: Tue, 29 Sep 2020 17:05:44 GMT
date: Thu, 15 Apr 2021 16:20:37 GMT
server: Windows-Azure-Table/1.0 Microsoft-HTTPAPI/2.0
x-content-type-options: nosniff
x-ms-version: '2019-02-02'
status:
code: 204
message: No Content
url: https://tablesteststorname.table.core.windows.net/Tables('pytableasynca6820b62')
url: https://seankaneprim.table.core.windows.net/Tables('pytableasynca6820b62')
version: 1
32 changes: 16 additions & 16 deletions sdk/tables/azure-data-tables/tests/recordings/test_table_cosmos.test_locale.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,27 @@ interactions:
DataServiceVersion:
- '3.0'
Date:
- Mon, 28 Sep 2020 17:25:37 GMT
- Thu, 15 Apr 2021 16:20:38 GMT
User-Agent:
- azsdk-python-data-tables/2019-07-07 Python/3.8.4 (Windows-10-10.0.19041-SP0)
- azsdk-python-data-tables/12.0.0b7 Python/3.9.0rc1 (Windows-10-10.0.19041-SP0)
x-ms-date:
- Mon, 28 Sep 2020 17:25:37 GMT
- Thu, 15 Apr 2021 16:20:38 GMT
x-ms-version:
- '2019-07-07'
- '2019-02-02'
method: POST
uri: https://tablestestcosmosname.table.cosmos.azure.com/Tables
uri: https://fake_cosmos_account.table.cosmos.azure.com/Tables
response:
body:
string: '{"TableName":"pytablesyncb3170bd8","odata.metadata":"https://tablestestcosmosname.table.cosmos.azure.com/$metadata#Tables/@Element"}'
string: '{"TableName":"pytablesyncb3170bd8","odata.metadata":"https://fake_cosmos_account.table.cosmos.azure.com/$metadata#Tables/@Element"}'
headers:
content-type:
- application/json;odata=minimalmetadata
date:
- Mon, 28 Sep 2020 17:25:38 GMT
- Thu, 15 Apr 2021 16:20:39 GMT
etag:
- W/"datetime'2020-09-28T17%3A25%3A38.7052039Z'"
- W/"datetime'2021-04-15T16%3A20%3A39.3542664Z'"
location:
- https://tablestestcosmosname.table.cosmos.azure.com/Tables('pytablesyncb3170bd8')
- https://fake_cosmos_account.table.cosmos.azure.com/Tables('pytablesyncb3170bd8')
server:
- Microsoft-HTTPAPI/2.0
transfer-encoding:
Expand All @@ -47,31 +47,31 @@ interactions:
body: null
headers:
Accept:
- '*/*'
- application/json
Accept-Encoding:
- gzip, deflate
Connection:
- keep-alive
Content-Length:
- '0'
Date:
- Mon, 28 Sep 2020 17:25:39 GMT
- Thu, 15 Apr 2021 16:20:39 GMT
User-Agent:
- azsdk-python-data-tables/2019-07-07 Python/3.8.4 (Windows-10-10.0.19041-SP0)
- azsdk-python-data-tables/12.0.0b7 Python/3.9.0rc1 (Windows-10-10.0.19041-SP0)
x-ms-date:
- Mon, 28 Sep 2020 17:25:39 GMT
- Thu, 15 Apr 2021 16:20:39 GMT
x-ms-version:
- '2019-07-07'
- '2019-02-02'
method: DELETE
uri: https://tablestestcosmosname.table.cosmos.azure.com/Tables('pytablesyncb3170bd8')
uri: https://fake_cosmos_account.table.cosmos.azure.com/Tables('pytablesyncb3170bd8')
response:
body:
string: ''
headers:
content-length:
- '0'
date:
- Mon, 28 Sep 2020 17:25:39 GMT
- Thu, 15 Apr 2021 16:20:39 GMT
server:
- Microsoft-HTTPAPI/2.0
status:
Expand Down
Loading