Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tables] Test fixes #18075

Merged
14 commits merged into from
Apr 19, 2021
Merged

[Tables] Test fixes #18075

14 commits merged into from
Apr 19, 2021

Conversation

seankane-msft
Copy link
Member

@seankane-msft seankane-msft commented Apr 15, 2021

Removes tests that are supported in tables but not cosmos.

@seankane-msft seankane-msft self-assigned this Apr 15, 2021
@ghost ghost added the Tables label Apr 15, 2021
@seankane-msft
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@seankane-msft
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -455,7 +455,7 @@ def list_entities(
"""
user_select = kwargs.pop("select", None)
if user_select and not isinstance(user_select, str):
user_select = ", ".join(user_select)
user_select = ",".join(user_select)
Copy link
Member Author

@seankane-msft seankane-msft Apr 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the space because cosmos will keep the space there on the returned object, which makes the deserialized object have a parameter with a preceding space. ie. my_entity[' value'] instead of my_entity['value'].

@seankane-msft seankane-msft requested a review from annatisch April 16, 2021 18:51
@seankane-msft
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Apr 19, 2021

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2a2cf6b into Azure:master Apr 19, 2021
@seankane-msft seankane-msft deleted the tables-test-fix branch May 18, 2021 16:12
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 3, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 3, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 3, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants