[formrecognizer] Adding more custom forms kwargs fixes #17397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
catalinaperalta
changed the title
catalinaperalta
requested review from
iscai-msft and
kristapratico
as code owners
kristapratico
approved these changes
Mar 17, 2021
kristapratico
added a commit
that referenced
this pull request
Mar 22, 2021
* [formrecognizer] Update generated code for preview.3 (#16833) * Adding generated code * update api-version dependent code * update test_receipt.py recordings * update generated code * update msrest dependency, add pages to custom form calls * skipping tests for undeployed endpoints * update pages doc comment * fix async operations and testcase handling * clean up response urls * adding content recordings * adding invoice test recordings * adding receipt recordings * update multiapi tests * update testcase and recordings * updating mgmt tests * update msrest requirement * update async client * [formrecognizer] Adding comment about image/bmp being accepted (#17130) * adding comment about image/bmp being accepted * add comments on async clients * update changelog * [formrecognizer] Add Identity Documents APIs (#17128) * Adding ID docs APIs and tests * comment test assertions, add recordings * pylint * fix type declaration * update changelog and descriptions * [formrecognizer] Adding sync and async samples for ID documents (#17186) * adding sync and async samples * rename sample function * get poller result instead of wait (#17299) * [formrecognizer] Add missing pages comments and tests (#17197) * add missing pages comments * update polling declaration in fr clients in custom forms * adding tests and recordings * updating changelog * remove extra pages tests in content tests * regenerate with latest preview 3 changes (#17400) * Adding more custom forms kwargs fixes (#17397) * pending id docs fixes (#17436) * [formrecognizer] rerecord tests for preview.3 (#17460) * enable business card and compose tests * enable training tests * rerecord training tests with correct multipage documents * rerecord copy tests with preview.3 * rerecord custom forms with preview.3 * rerecord invoices with preview.3 * rerecord receipts for preview.3 * rerecord mgmt tests for preview.3 Co-authored-by: Catalina Peralta <[email protected]> * add missing recording and unskip aad test * access correct env var for aad tests Co-authored-by: catalinaperalta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The poller in custom forms was breaking since the
clskwarg was being passed into it. Will add recordings once custom forms tests are unskipped.