Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] Update generated code for preview.3 #16833

Merged
merged 18 commits into from
Mar 5, 2021
Merged

[formrecognizer] Update generated code for preview.3 #16833

merged 18 commits into from
Mar 5, 2021

Conversation

catalinaperalta
Copy link
Member

@catalinaperalta catalinaperalta commented Feb 19, 2021 •
edited
Loading

Resolves #16682.
Addresses in part #16285.

@catalinaperalta catalinaperalta changed the title Update generated code [formrecognizer] Update generated code Feb 22, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@catalinaperalta catalinaperalta marked this pull request as ready for review February 22, 2021 17:12
@catalinaperalta
Copy link
Member Author

Some tests that are still enabled need to be looked into due to preview.3 changes. Also here's the issue tracking uncommenting the tests #16849.

@catalinaperalta catalinaperalta changed the title [formrecognizer] Update generated code [formrecognizer] Update generated code for preview.3 Feb 22, 2021
@catalinaperalta catalinaperalta mentioned this pull request Mar 1, 2021
Closed
kristapratico
kristapratico approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just looks like a few linting errors in CI to resolve but then let's merge! looks great :)

sdk/formrecognizer/azure-ai-formrecognizer/azure/ai/formrecognizer/_form_recognizer_client.py Outdated
raise ValueError(
"'pages' is only available for API version V2_1_PREVIEW and up"
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: will pages support for other prebuilts (business card, invoice) be in another PR? I wasn't sure cause I saw the issue tagged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I might have missed them, but at this point I'll open another PR after this one is merged in and address the missing pages support for the other prebuilts. I'll update the description on this PR to not close that issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, updated the description to not close the issue so I can add the other missing pages support.

@catalinaperalta catalinaperalta merged commit 40813ad into Azure:feature/form-2.1-preview.3 Mar 5, 2021
@catalinaperalta catalinaperalta deleted the updateGeneratedCode branch March 5, 2021 16:45
This was referenced Mar 12, 2021
Closed
Closed
kristapratico added a commit that referenced this pull request Mar 22, 2021
@kristapratico @catalinaperalta
Feature/form 2.1 preview.3 (#17485)
fc26007 
* [formrecognizer] Update generated code for preview.3 (#16833)

* Adding generated code

* update api-version dependent code

* update test_receipt.py recordings

* update generated code

* update msrest dependency, add pages to custom form calls

* skipping tests for undeployed endpoints

* update pages doc comment

* fix async operations and testcase handling

* clean up response urls

* adding content recordings

* adding invoice test recordings

* adding receipt recordings

* update multiapi tests

* update testcase and recordings

* updating mgmt tests

* update msrest requirement

* update async client

* [formrecognizer] Adding comment about image/bmp being accepted (#17130)

* adding comment about image/bmp being accepted

* add comments on async clients

* update changelog

* [formrecognizer] Add Identity Documents APIs (#17128)

* Adding ID docs APIs and tests

* comment test assertions, add recordings

* pylint

* fix type declaration

* update changelog and descriptions

* [formrecognizer] Adding sync and async samples for ID documents (#17186)

* adding sync and async samples

* rename sample function

* get poller result instead of wait (#17299)

* [formrecognizer] Add missing pages comments and tests (#17197)

* add missing pages comments

* update polling declaration in fr clients in custom forms

* adding tests and recordings

* updating changelog

* remove extra pages tests in content tests

* regenerate with latest preview 3 changes (#17400)

* Adding more custom forms kwargs fixes (#17397)

* pending id docs fixes (#17436)

* [formrecognizer] rerecord tests for preview.3 (#17460)

* enable business card and compose tests

* enable training tests

* rerecord training tests with correct multipage documents

* rerecord copy tests with preview.3

* rerecord custom forms with preview.3

* rerecord invoices with preview.3

* rerecord receipts for preview.3

* rerecord mgmt tests for preview.3

Co-authored-by: Catalina Peralta <[email protected]>

* add missing recording and unskip aad test

* access correct env var for aad tests

Co-authored-by: catalinaperalta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

Assignees
No one assigned
Labels
Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catalinaperalta @kristapratico