[text analytics] Healthcare n-ary relations #16997

iscai-msft · 2021-03-01T22:06:27Z

No description provided.

…into correct_healthcare * 'master' of https://github.com/Azure/azure-sdk-for-python: (30 commits) [EventGrid] Improve docs (Azure#16986) Fixed delete_blob method signature (Azure#16983) Fixed Content-MD5 serialization and typing (Azure#16987) [eventgrid] Black formatting and tests suite (Azure#16989) Appconfig perf test (Azure#16809) adds support for milliseconds on datetime objects (Azure#16847) [ServiceBus] Improve AMQP Error handling (Azure#16427) T2 resource 2021 02 26 (Azure#16961) T2 servicefabricmanagedclusters 2021 02 26 (Azure#16958) Update Prepare-Release script (Azure#16976) the previous filter was erroneously filtering out real files. (Azure#16978) Update azure-core minimum version (Azure#16968) update documention in depends section of eng_sys_checks.md (Azure#16967) version (Azure#16959) T2 web 2021 02 24 (Azure#16901) Change test pipeline to run in eastus2 (Azure#16950) Adding azure-devtools to mr-auth dev_requirements (Azure#16953) Add perf tests for eventgrid (Azure#16949) temp fix for canary tests (Azure#16945) Update get_package_properties to also return path to setup.py (Azure#16946) ...

check-enforcer · 2021-03-01T22:43:02Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

abhahn · 2021-03-01T23:00:08Z

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py

+    """A model representing a role in a relation.
+
+    For example, in "The subject took 100 mg of ibuprofen",
+    "100 mg" is a dosage entity fulfilling the role TODO


Does TODO need replaced with something?

@abhahn i think you're not looking at the latest commit. I had it in there before i knew what the possible roles were, have removed all todos in latest commit

abhahn

Looks good to me!

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py

abhahn

I think the only thing missing is normalized_text, otherwise everything looks great.

sdk/textanalytics/azure-ai-textanalytics/README.md

maririos · 2021-03-02T00:03:41Z

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py

    :vartype entities:
        list[~azure.ai.textanalytics.HealthcareEntity]
+    :ivar relations: Identified Healthcare relations between entities. For example, in the


I like your examples in docstrings. FYI @suhas92

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py

sdk/textanalytics/azure-ai-textanalytics/swagger/README.md

sdk/textanalytics/azure-ai-textanalytics/tests/test_analyze_healthcare.py

sdk/textanalytics/azure-ai-textanalytics/CHANGELOG.md

iscai-msft · 2021-03-02T17:10:30Z

...ics/azure-ai-textanalytics/samples/async_samples/sample_analyze_healthcare_entities_async.py

+        for relation in dosage_of_medication_relations:
+            # The DosageOfMedication relation should only contain the dosage and medication roles
+
+            dosage_role = next(filter(lambda x: x.name == "Attribute", relation.roles))


Have an issue tracking changing the role name from Attribute and Entity once service deploys

…into add_sample_check * 'master' of https://github.com/Azure/azure-sdk-for-python: (388 commits) [text analytics] add normalized_text (#17074) Renaming with_token identity function (#17066) Adapt to azure core's cloud event (#17063) align perf tests with js (#17069) [Perfstress][Storage] Added FileShare perf tests (#15834) [formrecognizer] Adding custom forms perf test (#16969) Fix LanguageShort typo (#17068) sas creds updates (#17065) [eventgrid] Fix Sample eh (#17064) [Perfstress][Storage] Added Datalake perf tests (#15861) [text analytics] Healthcare n-ary relations (#16997) ServiceBus dict-representation acceptance and kwarg-update functionality (#14807) [text analytics] add perf tests (#17060) Add cloud event to core (#16800) [Perf] Small fixes to storage-blob (#17055) [EG] Regenerate Code (#17053) Scrub batch shared keys (#17030) [Tables] Add SAS to tables (#16717) T2 containerservice 2021 03 03 (#17050) Addressing issues with CredScan (#16944) ...

…into add_query_kwarg * 'master' of https://github.com/Azure/azure-sdk-for-python: (69 commits) march release (Azure#16966) Release of Device Update for IoT Hub SDK for Python. (Azure#17005) Add Get-AllPackageInfoFromRepo (Azure#16947) Track1 package is incorrectly set as track2 (Azure#17075) [text analytics] add normalized_text (Azure#17074) Renaming with_token identity function (Azure#17066) Adapt to azure core's cloud event (Azure#17063) align perf tests with js (Azure#17069) [Perfstress][Storage] Added FileShare perf tests (Azure#15834) [formrecognizer] Adding custom forms perf test (Azure#16969) Fix LanguageShort typo (Azure#17068) sas creds updates (Azure#17065) [eventgrid] Fix Sample eh (Azure#17064) [Perfstress][Storage] Added Datalake perf tests (Azure#15861) [text analytics] Healthcare n-ary relations (Azure#16997) ServiceBus dict-representation acceptance and kwarg-update functionality (Azure#14807) [text analytics] add perf tests (Azure#17060) Add cloud event to core (Azure#16800) [Perf] Small fixes to storage-blob (Azure#17055) [EG] Regenerate Code (Azure#17053) ...

…into add_reprs * 'master' of https://github.com/Azure/azure-sdk-for-python: (71 commits) EG - more docs imrpovement (Azure#17079) [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057) march release (Azure#16966) Release of Device Update for IoT Hub SDK for Python. (Azure#17005) Add Get-AllPackageInfoFromRepo (Azure#16947) Track1 package is incorrectly set as track2 (Azure#17075) [text analytics] add normalized_text (Azure#17074) Renaming with_token identity function (Azure#17066) Adapt to azure core's cloud event (Azure#17063) align perf tests with js (Azure#17069) [Perfstress][Storage] Added FileShare perf tests (Azure#15834) [formrecognizer] Adding custom forms perf test (Azure#16969) Fix LanguageShort typo (Azure#17068) sas creds updates (Azure#17065) [eventgrid] Fix Sample eh (Azure#17064) [Perfstress][Storage] Added Datalake perf tests (Azure#15861) [text analytics] Healthcare n-ary relations (Azure#16997) ServiceBus dict-representation acceptance and kwarg-update functionality (Azure#14807) [text analytics] add perf tests (Azure#17060) Add cloud event to core (Azure#16800) ...

…into http_response_json * 'master' of https://github.com/Azure/azure-sdk-for-python: (165 commits) EG - more docs imrpovement (Azure#17079) [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057) march release (Azure#16966) Release of Device Update for IoT Hub SDK for Python. (Azure#17005) Add Get-AllPackageInfoFromRepo (Azure#16947) Track1 package is incorrectly set as track2 (Azure#17075) [text analytics] add normalized_text (Azure#17074) Renaming with_token identity function (Azure#17066) Adapt to azure core's cloud event (Azure#17063) align perf tests with js (Azure#17069) [Perfstress][Storage] Added FileShare perf tests (Azure#15834) [formrecognizer] Adding custom forms perf test (Azure#16969) Fix LanguageShort typo (Azure#17068) sas creds updates (Azure#17065) [eventgrid] Fix Sample eh (Azure#17064) [Perfstress][Storage] Added Datalake perf tests (Azure#15861) [text analytics] Healthcare n-ary relations (Azure#16997) ServiceBus dict-representation acceptance and kwarg-update functionality (Azure#14807) [text analytics] add perf tests (Azure#17060) Add cloud event to core (Azure#16800) ...

Adding missing advanced filters (Azure#16997)

* CodeGen from PR 16997 in Azure/azure-rest-api-specs Adding missing advanced filters (#16997) * version,CHANGELOG * test * update changelog manually Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: msyyc <[email protected]>

* CodeGen from PR 16997 in Azure/azure-rest-api-specs Adding missing advanced filters (Azure#16997) * version,CHANGELOG * test * update changelog manually Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: msyyc <[email protected]>

Adding missing advanced filters (Azure#16997)

* CodeGen from PR 16997 in Azure/azure-rest-api-specs Adding missing advanced filters (Azure#16997) * version,CHANGELOG * test * update changelog manually Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Yuchao Yan <[email protected]> Co-authored-by: msyyc <[email protected]>

iscai-msft added 6 commits March 1, 2021 12:06

add swagger readme.md to sdk and regenerate

b9c908b

remove related_entities

981c798

switch to new preview 4 healthcare models

3b9a17f

re-record and tests

885ed66

update samples

50efcb4

add repr tests

78371a2

iscai-msft requested a review from abhahn March 1, 2021 22:06

iscai-msft requested a review from kristapratico as a code owner March 1, 2021 22:06

ghost added the Cognitive - Text Analytics label Mar 1, 2021

iscai-msft requested review from maririos, mssfang, deyaaeldeen and suhas92 March 1, 2021 22:11

iscai-msft added 2 commits March 1, 2021 17:12

add changelog

096285c

add in makeshift role relation type enum

7dbd83f

abhahn reviewed Mar 1, 2021

View reviewed changes

abhahn approved these changes Mar 1, 2021

View reviewed changes

abhahn reviewed Mar 1, 2021

View reviewed changes

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py Show resolved Hide resolved

abhahn requested changes Mar 1, 2021

View reviewed changes

maririos reviewed Mar 2, 2021

View reviewed changes

sdk/textanalytics/azure-ai-textanalytics/CHANGELOG.md Outdated Show resolved Hide resolved

iscai-msft requested a review from abhahn March 2, 2021 15:55

iscai-msft added 3 commits March 2, 2021 11:04

make docstring and test name changes

5ab0dac

relations -> entity_relations

2d0c55b

add back dosage of medication extration to samples

7c0f15b

iscai-msft requested a review from maririos March 2, 2021 17:08

iscai-msft commented Mar 2, 2021

View reviewed changes

maririos approved these changes Mar 2, 2021

View reviewed changes

ignore swagger readme pattern check

e5915c0

iscai-msft requested review from danieljurek, mitchdenny, scbedd and weshaggard as code owners March 3, 2021 16:17

fix pylint error

28d1ba2

abhahn approved these changes Mar 3, 2021

View reviewed changes

iscai-msft merged commit 3a5fdc1 into Azure:master Mar 3, 2021

iscai-msft deleted the correct_healthcare branch March 3, 2021 19:20

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Dec 10, 2021

CodeGen from PR 16997 in Azure/azure-rest-api-specs

d06f42f

Adding missing advanced filters (Azure#16997)

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 5, 2022

CodeGen from PR 16997 in Azure/azure-rest-api-specs

30d2b62

Adding missing advanced filters (Azure#16997)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[text analytics] Healthcare n-ary relations #16997

[text analytics] Healthcare n-ary relations #16997

iscai-msft commented Mar 1, 2021

check-enforcer bot commented Mar 1, 2021

abhahn Mar 1, 2021

iscai-msft Mar 1, 2021

abhahn left a comment

abhahn left a comment

maririos Mar 2, 2021

iscai-msft Mar 2, 2021

[text analytics] Healthcare n-ary relations #16997

[text analytics] Healthcare n-ary relations #16997

Conversation

iscai-msft commented Mar 1, 2021

check-enforcer bot commented Mar 1, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

abhahn Mar 1, 2021

Choose a reason for hiding this comment

iscai-msft Mar 1, 2021

Choose a reason for hiding this comment

abhahn left a comment

Choose a reason for hiding this comment

abhahn left a comment

Choose a reason for hiding this comment

maririos Mar 2, 2021

Choose a reason for hiding this comment

iscai-msft Mar 2, 2021

Choose a reason for hiding this comment