Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appconfig perf test #16809

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Appconfig perf test #16809

merged 4 commits into from
Mar 1, 2021

Conversation

xiangyan99
Copy link
Member

No description provided.

@ghost ghost added the App Configuration Azure.ApplicationModel.Configuration label Feb 18, 2021
Copy link
Member

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:
Leaving up to Anna for final approval

def run_sync(self):
kv = ConfigurationSetting(
key=self.key,
value="VALUE" + str(uuid.uuid4()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We could move the str(uuid.uuid4()) into the constructor to avoid generating it in the perf test

@xiangyan99 xiangyan99 merged commit 878e384 into master Mar 1, 2021
@xiangyan99 xiangyan99 deleted the appconfig_perf_test branch March 1, 2021 17:20
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 1, 2021
…into correct_healthcare

* 'master' of https://github.com/Azure/azure-sdk-for-python: (30 commits)
  [EventGrid] Improve docs (Azure#16986)
  Fixed delete_blob method signature (Azure#16983)
  Fixed Content-MD5 serialization and typing (Azure#16987)
  [eventgrid] Black formatting and tests suite (Azure#16989)
  Appconfig perf test (Azure#16809)
  adds support for milliseconds on datetime objects (Azure#16847)
  [ServiceBus] Improve AMQP Error handling (Azure#16427)
  T2 resource 2021 02 26 (Azure#16961)
  T2 servicefabricmanagedclusters 2021 02 26 (Azure#16958)
  Update Prepare-Release script (Azure#16976)
  the previous filter was erroneously filtering out real files. (Azure#16978)
  Update azure-core minimum version (Azure#16968)
  update documention in depends section of eng_sys_checks.md (Azure#16967)
  version (Azure#16959)
  T2 web 2021 02 24 (Azure#16901)
  Change test pipeline to run in eastus2 (Azure#16950)
  Adding azure-devtools to mr-auth dev_requirements (Azure#16953)
  Add perf tests for eventgrid (Azure#16949)
  temp fix for canary tests (Azure#16945)
  Update get_package_properties to also return path to setup.py (Azure#16946)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants