Validate tenant IDs used in URLs #14955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
Client
mccoyp
previously approved these changes
Nov 3, 2020
| @@ -56,7 +56,7 @@ def test_user_agent(): | |||
| def test_request_url(authority): | |||
| """the credential should accept an authority, with or without scheme, as an argument or environment variable""" | |||
|
|
|||
| tenant_id = "expected_tenant" | |||
| tenant_id = "expected-tenant" | |||
There was a problem hiding this comment.
Does the constructor for VisualStudioCodeCredential need to validate the tenant ID as well, since it accepts a tenant_id keyword argument?
There was a problem hiding this comment.
It does! Thanks for catching that, I'd overlooked it.
mccoyp
approved these changes
Nov 4, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
…into add_invoice_multipage * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...
iscai-msft
pushed a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Nov 4, 2020
…into add_invoice_multipage_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) add more samples (Azure#15007) Address feedbacks: Rename type, improve readme (Azure#14905) Correct Visual Studio Code default environment name (Azure#14648) [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600) Validate tenant IDs used in URLs (Azure#14955) [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502) Raise minimum msal version to 1.6.0 (Azure#14992) update monitor to target '*' instead of azure-* (Azure#14985) Split create_basic_client into two methods (Azure#14673) [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925) String unicode deserial (Azure#14958) Clarified exceptions docs (Azure#14947) search-documents: correct method calls in sample (Azure#14980) Catch exceptions thrown by async download (Azure#14946) Increment package version after release of azure_eventgrid (Azure#14266) [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437) Service Bus Connection String Parser (Azure#14772) Remove AmendCommit parameter (Azure#14965) revert creation takes full object change (Azure#14957) [ServiceBus] Settlement move from Message to Receiver (Azure#14681) ...
movermeyer
added a commit
to movermeyer/python-configuration
that referenced
this pull request
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tenant ID validation everywhere a tenant ID is used to construct a URL, tests thereof, and fixes tests that were using invalid fake tenant IDs 😇
Closes #14821, closes #14354, closes #14853.