Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities #14437

Merged
merged 9 commits into from
Nov 3, 2020
Merged

[ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities #14437

merged 9 commits into from
Nov 3, 2020

Conversation

KieranBrantnerMagee
Copy link
Member

  • Adds renew, $management, and re-opening scenarios primarily
  • Add send_session_id and some additional hooks (batch/post receive, etc) to the stress test harness to allow this.

Note: This is the first half of two components for Stress Test readiness, making individual PRs for ease-of-read. The latter work will bolster the metrics we examine and allow for more depth of test-pass criteria. (failure rates, latencies, system perf, etc.)

@KieranBrantnerMagee
Add additional stress test coverage to ensure parity with cross-langu…
4d11ee3 
…age priorities. (Renew, $management, and re-opening scenarios primarily)

Add send_session_id and some additional hooks (batch/post receive, etc) to the stress test harness to allow this.
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Oct 12, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] November milestone Oct 12, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Oct 12, 2020
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee KieranBrantnerMagee linked an issue Oct 26, 2020 that may be closed by this pull request
[ServiceBus] Align stress tests to cross-language min-bar before GA #14338
Closed
@Azure Azure deleted a comment from KieranBrantnerMagee Oct 26, 2020
KieranBrantnerMagee and others added 3 commits October 26, 2020 16:35
@KieranBrantnerMagee @yunhaoling
Apply suggestions from code review
dcfa4bf 
AutoLockRenew->AutoLockRenewer
Comment clarity in stress test logic.

Co-authored-by: Adam Ling (MSFT) <[email protected]>
@KieranBrantnerMagee
Fix session_id population in stress test framework (was on send inste…
0273217 
…ad of message)
@KieranBrantnerMagee
Merge remote-tracking branch 'upstream/master' into kibrantn/serviceb…
17c0037 
…us/track2-preview8-stress-test-min-bar-coverage
rakshith91
rakshith91 previously approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@rakshith91 rakshith91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KieranBrantnerMagee
PR fixes; make session test actually test sessions, adjust naming to …
a61e8ff 
…normalize with our conventions now that this tool is more formalized, and touch up the autorenew logic to be more robust against delays.
@KieranBrantnerMagee
Merge remote-tracking branch 'upstream/master' into kibrantn/serviceb…
a3d4873 
…us/track2-preview8-stress-test-min-bar-coverage
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling
yunhaoling approved these changes Oct 31, 2020
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KieranBrantnerMagee KieranBrantnerMagee merged commit a912eec into Azure:master Nov 3, 2020
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Nov 4, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
fd5c973 
…into add_invoice_multipage

* 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits)
  add more samples (Azure#15007)
  Address feedbacks: Rename type, improve readme (Azure#14905)
  Correct Visual Studio Code default environment name (Azure#14648)
  [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600)
  Validate tenant IDs used in URLs (Azure#14955)
  [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502)
  Raise minimum msal version to 1.6.0 (Azure#14992)
  update monitor to target '*' instead of azure-* (Azure#14985)
  Split create_basic_client into two methods (Azure#14673)
  [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925)
  String unicode deserial (Azure#14958)
  Clarified exceptions docs (Azure#14947)
  search-documents: correct method calls in sample (Azure#14980)
  Catch exceptions thrown by async download (Azure#14946)
  Increment package version after release of azure_eventgrid (Azure#14266)
  [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437)
  Service Bus Connection String Parser (Azure#14772)
  Remove AmendCommit parameter (Azure#14965)
  revert creation takes full object change (Azure#14957)
  [ServiceBus] Settlement move from Message to Receiver (Azure#14681)
  ...
iscai-msft pushed a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Nov 4, 2020
@KieranBrantnerMagee @yunhaoling @iscai-msft
[ServiceBus] Add additional stress test coverage to ensure parity wit…
b9f0419 
…h cross-language priorities (Azure#14437)

* Add additional stress test coverage to ensure parity with cross-language priorities.  (Renew, $management, and re-opening scenarios primarily)
* Add send_session_id and some additional hooks (batch/post receive, etc) to the stress test harness to allow this.
* Fix session_id population in stress test framework (was on send instead of message)
* PR fixes; make session test actually test sessions, adjust naming to normalize with our conventions now that this tool is more formalized, and touch up the autorenew logic to be more robust against delays.

Co-authored-by: Adam Ling (MSFT) <[email protected]>
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Nov 4, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
aa32808 
…into add_invoice_multipage_tests

* 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits)
  add more samples (Azure#15007)
  Address feedbacks: Rename type, improve readme (Azure#14905)
  Correct Visual Studio Code default environment name (Azure#14648)
  [ServiceBus] Adjust AutoLockRenewer to only allow registration of intended types (ReceivedMessage and ServiceBusSession) (Azure#14600)
  Validate tenant IDs used in URLs (Azure#14955)
  [ServiceBus] Make sub-client initializers internal (add '_' to from_conn_str for receiver/sender) (Azure#14502)
  Raise minimum msal version to 1.6.0 (Azure#14992)
  update monitor to target '*' instead of azure-* (Azure#14985)
  Split create_basic_client into two methods (Azure#14673)
  [ServiceBus] receive related methods/constructor raise error if given max_wait_time <= 0 (Azure#14925)
  String unicode deserial (Azure#14958)
  Clarified exceptions docs (Azure#14947)
  search-documents: correct method calls in sample (Azure#14980)
  Catch exceptions thrown by async download (Azure#14946)
  Increment package version after release of azure_eventgrid (Azure#14266)
  [ServiceBus] Add additional stress test coverage to ensure parity with cross-language priorities (Azure#14437)
  Service Bus Connection String Parser (Azure#14772)
  Remove AmendCommit parameter (Azure#14965)
  revert creation takes full object change (Azure#14957)
  [ServiceBus] Settlement move from Message to Receiver (Azure#14681)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request May 18, 2021
@thinkdavid
CodeGen from PR 14215 in Azure/azure-rest-api-specs
a0e2f9c 
add AVS 2021-06-01 API (Azure#14215)

* add AVS 2021-06-01 API

* add cmdlets custom word

* rename ScriptCmdlet cmdletDescription to description (Azure#14218)

* Adding optional to the script parameter (Azure#14437)

Co-authored-by: David Becher <[email protected]>

Co-authored-by: david becher <[email protected]>
Co-authored-by: David Becher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhaoling yunhaoling yunhaoling approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@rakshith91 rakshith91 Awaiting requested review from rakshith91

Assignees

@KieranBrantnerMagee KieranBrantnerMagee

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2020] November
Development

Successfully merging this pull request may close these issues.

[ServiceBus] Align stress tests to cross-language min-bar before GA
3 participants
@KieranBrantnerMagee @rakshith91 @yunhaoling