-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove shared #12883
Remove shared #12883
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks really good, you'll notice that p much all of my comments are nits. thanks so much for doing this!
sdk/tables/azure-data-tables/azure/data/tables/aio/_table_client_async.py
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/azure/data/tables/_authentication.py
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/azure/data/tables/_table_client.py
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/samples/creation_deletion_of_table.py
Outdated
Show resolved
Hide resolved
sdk/tables/azure-data-tables/azure/data/tables/shared_access_signature.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty much ready to approve, just a couple tiny changes
sdk/tables/azure-data-tables/azure/data/tables/_table_shared_access_signature.py
Show resolved
Hide resolved
error_message = storage_error.message | ||
additional_data = {} | ||
try: | ||
error_body = ContentDecodePolicy.deserialize_from_http_generics(storage_error.response) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you able to confirm whether this step was necessary for errors raised by Tables?
Before and after the swagger update from Connie's PR?
sdk/tables/azure-data-tables/azure/data/tables/_table_service_client_base.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add pipeline policy and Elapsed Time Metric (Azure#12883) * Add pipeline policy and ElapsedTime Policy * adding missing objects * fix schema validation * fix prettier issues Co-authored-by: Kalyan C Kesireddy <[email protected]>
* CodeGen from PR 12883 in Azure/azure-rest-api-specs Add pipeline policy and Elapsed Time Metric (#12883) * Add pipeline policy and ElapsedTime Policy * adding missing objects * fix schema validation * fix prettier issues Co-authored-by: Kalyan C Kesireddy <[email protected]> * test,version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Kalyan C Kesireddy <[email protected]> Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Fixes #12785
Collapses the shared directory and decreases the number of files. Deletes any unused functions or variables