Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of _shared folder #12785

Closed
LibbaLawrence opened this issue Jul 29, 2020 · 1 comment · Fixed by #12883
Closed

Get rid of _shared folder #12785

LibbaLawrence opened this issue Jul 29, 2020 · 1 comment · Fixed by #12883
Assignees
@seankane-msft
Labels
Client This issue points to a problem in the data-plane of the library. Tables
Milestone
[2020] September

Comments

@LibbaLawrence
Copy link
Contributor

No description provided.

@LibbaLawrence LibbaLawrence added Client This issue points to a problem in the data-plane of the library. Tables labels Jul 29, 2020
@seankane-msft
Copy link
Member

Factor out methods that are imported from the _shared directory and place them in appropriate files in the root. Most will probably belong in serialize, deserialize, and the models file. Afterwards, remove the shared directory.

In addition, with the imports verify that all imports from the tables directory are relative imports

@seankane-msft seankane-msft added this to the [2020] September milestone Jul 30, 2020
@seankane-msft seankane-msft mentioned this issue Aug 4, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@seankane-msft seankane-msft

Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Milestone
[2020] September
Development

Successfully merging a pull request may close this issue.

Remove shared seankane-msft/azure-sdk-for-python
2 participants
@LibbaLawrence @seankane-msft