Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Delete swagger file #12097

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Conversation

YijunXieMS
Copy link
Contributor

@YijunXieMS YijunXieMS commented Jun 17, 2020

It will go to repository azure-rest-api-specs-pr in the near future while it's under development at here

It will go to azure-rest-api-specs-pr sometime.
@YijunXieMS YijunXieMS added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jun 17, 2020
@KieranBrantnerMagee
Copy link
Member

Do we have a PR for it moving into its new home? Both to give breadcrumbs of continuity in this PR, and to make sure we keep tracking any changes/that there's a minimal amount of time with "core parts of our system being untracked"

@YijunXieMS
Copy link
Contributor Author

Do we have a PR for it moving into its new home? Both to give breadcrumbs of continuity in this PR, and to make sure we keep tracking any changes/that there's a minimal amount of time with "core parts of our system being untracked"

Not yet. We added many new things and it needs some clean-up (mainly Description of entities, properties and operations) to create a PR. The new file location is still in my own fork. Expected to create a PR sometime in this release to merge to azure-rest-api-specs-pr master.

@KieranBrantnerMagee
Copy link
Member

Do we have a PR for it moving into its new home? Both to give breadcrumbs of continuity in this PR, and to make sure we keep tracking any changes/that there's a minimal amount of time with "core parts of our system being untracked"

Not yet. We added many new things and it needs some clean-up (mainly Description of entities, properties and operations) to create a PR. The new file location is still in my own fork. Expected to create a PR sometime in this release to merge to azure-rest-api-specs-pr master.

Works for me. My high order bit was just making sure we had a contiguous paper trail of this work until it landed in a final home, if someone ever needed to track it back and learn the history. Will approve++ (If you're feeling super motivated, it'd also be nice to link the final PR into api-specs to this one, but I'm bikeshedding for completeness.)

@YijunXieMS YijunXieMS merged commit 158f7e1 into master Jun 23, 2020
@YijunXieMS YijunXieMS deleted the servicebus_remove_swagger branch June 23, 2020 16:17
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 23, 2020
…into regenerate_certs

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Resolve Pip Related Errors (Azure#12157)
  [Service Bus] Delete swagger file (Azure#12097)
  Add set_delete_after_tag as a parameter on ResourceGroupPreparer (Azure#11749)
  Custom Vision Training: release_3_3 Prediction: release_3_1 (Azure#12105)
  Don't redact Key Vault header values in logs (Azure#12077)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jun 23, 2020
…into regenerate_keys

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Resolve Pip Related Errors (Azure#12157)
  [Service Bus] Delete swagger file (Azure#12097)
  Add set_delete_after_tag as a parameter on ResourceGroupPreparer (Azure#11749)
  Custom Vision Training: release_3_3 Prediction: release_3_1 (Azure#12105)
  Don't redact Key Vault header values in logs (Azure#12077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants