Add set_delete_after_tag as a parameter on ResourceGroupPreparer #11749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat test-prepared RGs can be automatically cleaned up by engsys. Populate this into the two "default helper RG preparers" (randomized/cached) to implicitly opt-in the tests consuming those into the best practice. (Currently this is a very limited set of SDKs)
KieranBrantnerMagee
added
the
Client
KieranBrantnerMagee
requested review from
lmazuel,
annatisch,
iscai-msft and
yunhaoling
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
reviewed
Jun 3, 2020
lmazuel
previously approved these changes
Jun 10, 2020
Although we should not be relying on arg order, to be extra careful and set good precedent new args should be appended to the back of the arglist.
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lmazuel
approved these changes
Jun 16, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 23, 2020
…into regenerate_certs * 'master' of https://github.com/Azure/azure-sdk-for-python: Resolve Pip Related Errors (Azure#12157) [Service Bus] Delete swagger file (Azure#12097) Add set_delete_after_tag as a parameter on ResourceGroupPreparer (Azure#11749) Custom Vision Training: release_3_3 Prediction: release_3_1 (Azure#12105) Don't redact Key Vault header values in logs (Azure#12077)
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 23, 2020
…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: Resolve Pip Related Errors (Azure#12157) [Service Bus] Delete swagger file (Azure#12097) Add set_delete_after_tag as a parameter on ResourceGroupPreparer (Azure#11749) Custom Vision Training: release_3_3 Prediction: release_3_1 (Azure#12105) Don't redact Key Vault header values in logs (Azure#12077)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables test-prepared RGs to be automatically cleaned up by engsys.
Populate this into the two "default helper RG preparers" (randomized/cached) to implicitly opt-in the tests consuming those into the best practice. (Currently this is a very limited set of SDKs, including the ServiceBus tests, thus my running them to test below)
(Excuse the somewhat grabbag set of reviewers, tried to get both "somewhat wide reach, folks who touch these core bits, and folks who touch other libs", feel free to add any friends you think would care)