Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suspicious uncovered code in _create_message (service bus __init__) #44

Closed
huguesv opened this issue Jun 18, 2012 · 1 comment
Closed

suspicious uncovered code in _create_message (service bus __init__) #44

huguesv opened this issue Jun 18, 2012 · 1 comment

Comments

@huguesv
Copy link
Contributor

huguesv commented Jun 18, 2012

The second line in this code snippet is not covered according to code coverage result. If you know how to trigger it, please mention it here. If it ever gets executed, it will not work because broker_properties is incorrectly getting passed for the message_type parameter.

if message_type == None: 
message = Message(respbody, service_instance, message_location, custom_properties, broker_properties) 
else: 
message = Message(respbody, service_instance, message_location, custom_properties, message_type, broker_properties)
@huguesv
Copy link
Contributor Author

huguesv commented Jun 21, 2012

Verified as fixed.

@huguesv huguesv closed this as completed Jun 21, 2012
yunhaoling pushed a commit to yunhaoling/azure-sdk-for-python that referenced this issue Mar 25, 2019
@annatisch
Merge pull request Azure#44 from annatisch/eh_scenarios
dd38016 
Stability improvements
azclibot pushed a commit to azclibot/azure-sdk-for-python that referenced this issue Dec 23, 2021
@smile37773 @leonard520
@ninpan-ms @zhoufenqin
CodeGen from PR 17141 in Azure/azure-rest-api-specs
c3d5c7f 
[Hub Generated] Add Microsoft.AppPlatform/Spring new pricing tier on API version 2022-01-01-preview (Azure#17141)

* copy from last api version

* Add system data and example

* Add availability zones change

* Configuration Service

* Service Registry

* Gateway

* API portal

* App and Deployment

* BuildServices/Builds/Builders/BuildResults

* BuildPackBindings

* fix swagger of build service (Azure#43)

* fix swagger of build service

* fix

* fix: add agentPool in BuildProperties (Azure#44)

* Add fqdn in service resource (Azure#45)

Co-authored-by: Xiaoyun Ding <[email protected]>

* Change appName to appResourceId (Azure#46)

* Change appName to appResourceId

* fix

* Add resource id to connect resources

* Change operatorRuntimeState to resourceRequest (Azure#49)

* Change appName to appResourceId

* rename sourceGateways to gatewayIds

* Change operatorRuntimeState to resourceRequest

* feat: update agent pool swagger (Azure#50)

* Update 201 descriptions about header

* add get build (Azure#51)

* Remove 202 for PUT

* List and Get supportedBuildpacks

* set active deployment should be async

* Update setActiveDeployments response body

* ContentCertificateProperties.content should be secret

* Add jvmOptions for Jar type

Co-authored-by: Qingyi Liu <[email protected]>
Co-authored-by: Xiaoyun Ding <[email protected]>
Co-authored-by: Xiaoyun Ding <[email protected]>
Co-authored-by: ninpan-ms <[email protected]>
Co-authored-by: zhoufenqin <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huguesv